Skip to content

Commit

Permalink
Fix docker wait for macos
Browse files Browse the repository at this point in the history
  • Loading branch information
johscheuer committed Jul 2, 2017
1 parent 9848cdb commit 546cb0c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion build/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,9 @@ function kube::build::short_hash() {
# a workaround for bug https://github.com/docker/docker/issues/3968.
function kube::build::destroy_container() {
"${DOCKER[@]}" kill "$1" >/dev/null 2>&1 || true
"${DOCKER[@]}" wait "$1" >/dev/null 2>&1 || true
if docker inspect --type=container "$1" >/dev/null 2>&1; then

This comment has been minimized.

Copy link
@sttts

sttts Jul 11, 2017

Contributor

that's a race, isn't it?

"${DOCKER[@]}" wait "$1" >/dev/null 2>&1 || true
fi
"${DOCKER[@]}" rm -f -v "$1" >/dev/null 2>&1 || true
}

Expand Down

0 comments on commit 546cb0c

Please sign in to comment.