Job: Update the comment when the Job already has the SuccessCriteriaM…

…et condition Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kubernetes · Feb 29, 2024 · 134a16f · 134a16f
1 parent af26f57
commit 134a16f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/controller/job/job_controller.go b/pkg/controller/job/job_controller.go
@@ -813,6 +813,8 @@ func (jm *Controller) syncJob(ctx context.Context, key string) (rErr error) {
 		jobCtx.successCondition = findConditionByType(jobCtx.job.Status.Conditions, batch.JobSuccessCriteriaMet)
 	}
 
+	// Given that the Job already has the SuccessCriteriaMet condition, the termination condition already had confirmed in another cycle.
+	// So, the job-controller evaluates the podFailurePolicy only when the Job doesn't have the SuccessCriteriaMet condition.
 	if feature.DefaultFeatureGate.Enabled(features.JobPodFailurePolicy) && jobCtx.successCondition == nil {
 		if failureTargetCondition := findConditionByType(job.Status.Conditions, batch.JobFailureTarget); failureTargetCondition != nil {
 			jobCtx.failureCondition = newFailedConditionForFailureTarget(failureTargetCondition, jm.clock.Now())