Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use the functions in component-helpers to calculate pod resource #1688

Closed
lixiv opened this issue Dec 23, 2024 · 3 comments
Closed

Refactor to use the functions in component-helpers to calculate pod resource #1688

lixiv opened this issue Dec 23, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@lixiv
Copy link
Contributor

lixiv commented Dec 23, 2024

What would you like to be added:

Refactor the code to use library functions in component-helpers:
https://github.com/kubernetes/kubectl/blob/master/pkg/util/resource/resource.go#L40
https://github.com/kubernetes/kubectl/blob/master/pkg/util/resource/resource.go#L96

Why is this needed:

PodRequests and PodLimits method exists in staging/src/k8s.io/component-helpers/resource/helpers.go. Refactor the code to avoid duplicating podRequests and podLimits method.
@lixiv lixiv added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 23, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lixiv lixiv mentioned this issue Dec 23, 2024
Open
@ardaguclu
Copy link
Member

When I checked in the referenced PR, there are plenty of changes and it is really hard to confirm that this won't create any regressions. In my opinion, we can leave it as is. However, maintainers can still drop comments on the PR but there is no need to have a separate issue for this;
/close

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: Closing this issue.

In response to this:

When I checked in the referenced PR, there are plenty of changes and it is really hard to confirm that this won't create any regressions. In my opinion, we can leave it as is. However, maintainers can still drop comments on the PR but there is no need to have a separate issue for this;
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ardaguclu @lixiv @k8s-ci-robot