Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove --cri-socket flag from kubeadm upgrade apply #1356

Closed
2 tasks done
rosti opened this issue Jan 21, 2019 · 8 comments · Fixed by kubernetes/kubernetes#85044
Closed
2 tasks done

Deprecate and remove --cri-socket flag from kubeadm upgrade apply #1356

rosti opened this issue Jan 21, 2019 · 8 comments · Fixed by kubernetes/kubernetes#85044
Assignees
@neolit123
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@rosti
Copy link

rosti commented Jan 21, 2019 •
edited by neolit123
Loading

For historical reasons kubeadm upgrade apply accepts a --cri-socket flag.
This is no longer needed, because the CRI socket of the node is stored in the NodeRegistrationOptions of the node at the cluster.
During kubeadm upgrade apply it is much safer and less error prone to fetch the CRI socket from the cluster, rather than rely on the user to supply the same value as upon kubeadm init or kubeadm join.

Timeline:

  1. Mark the flag as deprecated (in 1.14).
  1. Remove the flag (+3 releases from deprecation - from 1.17 on wards)

/kind cleanup
/lifecycle active
/assign
/priority important-longterm
/cc @fabriziopandini
@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 21, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 21, 2019
@RA489
Copy link
Contributor

RA489 commented Jan 23, 2019

@rosti I can look into it.

@rosti
Copy link
Author

rosti commented Jan 23, 2019

@RA489 The first part of this is already done as part of the above mentioned PR. The second part (the actual removal) is going to be done after (at least) 3 minor releases due to deprecation policies.
Feel free to work on that when the time comes.

@timothysc timothysc added this to the Next milestone Jan 28, 2019
@bart0sh bart0sh mentioned this issue Jan 30, 2019
Closed
@neolit123 neolit123 removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 22, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2019
@neolit123
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2019
@neolit123 neolit123 modified the milestones: Next, v1.17 Oct 10, 2019
@neolit123 neolit123 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 10, 2019
@neolit123
Copy link
Member

should be removed in 1.17
added help-wanted please see OP for details:
#1356 (comment)

@yastij
Copy link
Member

yastij commented Oct 10, 2019

/assign
/priority important-soon

@neolit123 - I'll take a look

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 10, 2019
@neolit123
Copy link
Member

@yastij thanks.

@neolit123 neolit123 modified the milestones: v1.17, v1.18 Nov 9, 2019
@neolit123 neolit123 mentioned this issue Nov 9, 2019
Merged
@neolit123 neolit123 removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 9, 2019
@neolit123 neolit123 assigned neolit123 and unassigned yastij Nov 9, 2019
@neolit123 neolit123 added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Nov 9, 2019
@neolit123
Copy link
Member

sent PR here: kubernetes/kubernetes#85044

@neolit123 neolit123 mentioned this issue Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kubeadm: remove the deprecated "--cri-socket" flag for "upgrade apply" neolit123/kubernetes
7 participants
@timothysc @neolit123 @rosti @yastij @k8s-ci-robot @fejta-bot @RA489