Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify check require-kubeconfig kube version #4357

Merged
merged 1 commit into from
Feb 2, 2018
Merged

modify check require-kubeconfig kube version #4357

merged 1 commit into from
Feb 2, 2018

Conversation

zhangxiaoyu-zidif
Copy link

modify check require-kubeconfig kube version
Kubernetes version 1.9 does not need require-kubeconfig any more.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2018
@zhangxiaoyu-zidif
Copy link
Author

/cc @justinsb

@k8s-ci-robot k8s-ci-robot requested a review from justinsb January 30, 2018 09:32
chrislovecnm
chrislovecnm approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it manually be added and thus we need to validate that we do not add it?

Wonder if this is going to have issues with upgrades

@zhangxiaoyu-zidif
Copy link
Author

ref: kubernetes/kubernetes#41161
as Jordan said in kubernetes/kubernetes#58367 (comment)

@zhangxiaoyu-zidif
Copy link
Author

as I remembered if we pass a non-existed parameter, the kubelet process could not start. just like pass api-server to kubelet after v1.8.

@chrislovecnm
Copy link
Contributor

Once it is deprecated we cannot set the value, but we still have 1.5 users

@justinsb
Copy link
Member

justinsb commented Feb 2, 2018

/lgtm

Thanks @zhangxiaoyu-zidif !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, zhangxiaoyu-zidif

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4e284e9 into kubernetes:master Feb 2, 2018
@zhangxiaoyu-zidif
Copy link
Author

@chrislovecnm yes， you are right，I need to think how to resolve it， but I think we could refer to some operations when api-servers was depreciated. =)

@pengisgood pengisgood mentioned this pull request Apr 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangxiaoyu-zidif @chrislovecnm @justinsb @k8s-ci-robot