Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops replace --create not working #4012

Closed
joan38 opened this issue Dec 5, 2017 · 11 comments · Fixed by #5182
Closed

kops replace --create not working #4012

joan38 opened this issue Dec 5, 2017 · 11 comments · Fixed by #5182
Assignees
@gambol99
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@joan38
Copy link

joan38 commented Dec 5, 2017 •
edited
Loading 

> ./kops replace --create -f cluster-benji.yml
Error: unknown flag: --create
Usage:
  kops replace -f FILENAME [flags]

Examples:
  # Replace a cluster desired configuration using a YAML file
  kops replace -f my-cluster.yaml
  
  # Note, if the resource does not exist the command will error, use --force to provision resource
  kops replace -f my-cluster.yaml --force

Flags:
  -f, --filename stringSlice   A list of one or more files separated by a comma.
      --force                  Force any changes, which will also create any non-existing resource

Global Flags:
      --alsologtostderr                  log to standard error as well as files
      --config string                    config file (default is $HOME/.kops.yaml)
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory
      --logtostderr                      log to standard error instead of files (default false)
      --name string                      Name of cluster
      --state string                     Location of state storage (default "s3://drivetribe-kubernetes-state-store")
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          log level for V logs
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging


unknown flag: --create
> ./kops version
Version 1.8.0 (git-5099bc5)

kops replace --create will now replace-or-create, which is useful for CI / automated workflows

According to the release note that should have worked?
@gambol99
Copy link
Contributor

gambol99 commented Dec 5, 2017

hi @joan38 ... this was added in #3089, the flag was originally --create and then after discussion changed to --force . Where's the documentation indicating the --create so we update

@gambol99
Copy link
Contributor

gambol99 commented Dec 5, 2017

/assign @gambol99

@joan38
Copy link
Author

joan38 commented Dec 7, 2017 •
edited
Loading

I see.
Do you know why we didn't go with kops apply for consistancy?

Thanks @gambol99

@gambol99
Copy link
Contributor

gambol99 commented Dec 8, 2017

no worries :-) .... also in regard to the 'apply' ... taken from the original PR

apply for kubectl is much more complex logic than replace (take a peek at kubernetes/kubernetes#1702 ). Annoyingly it is all done client-side in kubectl so it isn't something we can just drop in yet. But that's why I'm wary of kops apply

@gambol99
Copy link
Contributor

/close

@wendorf
Copy link
Contributor

wendorf commented Jan 12, 2018

The 1.8.0 release notes still document kops replace --create. Can that be edited?

@chrislovecnm
Copy link
Contributor

@wendorf I will reopen, and if you could submit a PR that would be awesome, otherwise it will go into the queue.

Thanks

Chris

@chrislovecnm chrislovecnm reopened this Jan 12, 2018
@wendorf
Copy link
Contributor

wendorf commented Jan 13, 2018

Unfortunately, I'm waiting on an org CLA to submit a couple PRs, but the issue is in both the release notes markdown as well as the Github release's notes, which I wouldn't be able to PR.

@chrislovecnm
Copy link
Contributor

No worries! Thanks, and hopefully they will sign it soon.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 14, 2018
wendorf added a commit to wendorf/kops that referenced this issue May 18, 2018
@wendorf
1.8 release notes correctly note replace --force
bd2dea1 
`kops replace --create` was replaced with `kops replace --force`, but
the release notes were not updated to match this.

When merging, https://github.com/kubernetes/kops/releases/tag/1.8.0 should be
manually updated to match this change.

fixes kubernetes#4012
@wendorf wendorf mentioned this issue May 18, 2018
Merged
liranp pushed a commit to spotinst/kubernetes-kops that referenced this issue May 24, 2018
@wendorf @liranp
1.8 release notes correctly note replace --force
94a9f7f 
`kops replace --create` was replaced with `kops replace --force`, but
the release notes were not updated to match this.

When merging, https://github.com/kubernetes/kops/releases/tag/1.8.0 should be
manually updated to match this change.

fixes kubernetes#4012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gambol99 gambol99

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.8 release notes correctly note replace --force wendorf/kops
6 participants
@chrislovecnm @wendorf @joan38 @gambol99 @k8s-ci-robot @fejta-bot