Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for ProxyProtocol with AWS ELB to get Client IP #175

Closed
ohaiwalt opened this issue Jan 26, 2017 · 10 comments
Closed

Documentation for ProxyProtocol with AWS ELB to get Client IP #175

ohaiwalt opened this issue Jan 26, 2017 · 10 comments

Comments

@ohaiwalt
Copy link
Contributor

ohaiwalt commented Jan 26, 2017 •
edited
Loading

Hi,

While attempting to get ProxyProtocol working on AWS to get Client IPs, I followed the docs and added the ProxyProtocol policy to the ELB and use-proxy-protocol: "true" on the nginx-ingress-controller configMap, I ran into what seemed like a brick wall and it was only after talking with @justinsb did I discover that there's an nginx-ingress-controller service annotation for that, described in kubernetes/kubernetes#24569

What I was missing was this doing a string match against this constant so the ProxyProtocol policy I had on the ELB wasn't working due to being incorrectly named.

I'd be happy to submit a PR for some updates, creating the issue for anyone else who runs into this.
@whereisaaron
Copy link
Contributor

I saw your issue in the chat but you solved it with a Service annotation like below. Note for others, despite the discussion right now, the only allowed value is "*".

  annotations:
    # Proxy Protocol must also be enabled in the nginx config map 'use-proxy-protocol'
    service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: "*"

@aledbf
Copy link
Member

aledbf commented Sep 29, 2017

Closing. This example shows how it's possible to configure the ELB https://github.com/kubernetes/ingress/tree/master/examples/aws/nginx

@aledbf aledbf closed this as completed Sep 29, 2017
@PassKit
Copy link

PassKit commented Oct 15, 2017

@aledbf your link is a 404

@aledbf
Copy link
Member

aledbf commented Oct 15, 2017

@PassKit https://github.com/kubernetes/ingress-nginx/tree/master/examples/aws

@PassKit
Copy link

PassKit commented Oct 17, 2017

Also a 404!

@blairccx
Copy link

FWIW, I think this is where the aforementioned broken links would take you:
https://github.com/kubernetes/ingress-nginx/tree/master/deploy/provider/aws

@adubkov
Copy link

adubkov commented Jul 17, 2019

again 404.

@nvtkaszpir
Copy link
Member

https://github.com/kubernetes/ingress-nginx/blob/master/deploy/aws/l4/service-l4.yaml

@paulashbourne
Copy link

https://github.com/kubernetes/ingress-nginx/blob/master/deploy/aws/l4/service-l4.yaml

404

@aledbf
Copy link
Member

aledbf commented Jun 10, 2020

404

@paulashbourne the deployment now is just one yaml file.
Please check https://kubernetes.github.io/ingress-nginx/deploy/#network-load-balancer-nlb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@aledbf @whereisaaron @nvtkaszpir @paulashbourne @adubkov @ohaiwalt @blairccx