Skip to content

Wrong validation for permanent-redirect and temporal-redirect annotation valuesΒ #12709

Open
@N4SoftwareNinja

Description

Hi everyone,

I think in this file there is a wrong validator for the values of permanent-redirect and temporal-redirect annotation used.

Reasoning: It should be possible to use variables like "$request_uri" for redirecting to the same path as in the original request for example, but this is blocked by the validation because the $ is not allowed.
If I use a configuration-snippet with the following content, it works fine:

return 301 https://wheelscompany.com/$request_uri;

So for me it looks like if URLWithNginxVariableRegex should be the correct Regex to be used at this point.

Metadata

Assignees

No one assigned

    Labels

    needs-kindIndicates a PR lacks a `kind/foo` label and requires one.needs-priorityneeds-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions