Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KEP 2681 to GA #4418

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Move KEP 2681 to GA #4418

merged 1 commit into from
Feb 2, 2024

Conversation

wzshiming
Copy link
Member

  • One-line PR description:

Move KEP 2681 to GA

  • Other comments:

/cc @thockin

@k8s-ci-robot k8s-ci-robot requested a review from thockin January 19, 2024 11:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2024
@wzshiming
Copy link
Member Author

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t January 19, 2024 11:15
@wzshiming wzshiming mentioned this pull request Jan 19, 2024
Closed
12 tasks
@aojea
Copy link
Member

aojea commented Jan 19, 2024

pluralization of the pod.status.HostIP and exposure to the downward API, no bugs reported and e2e in place https://github.com/kubernetes/kubernetes/blob/c6887b1c0059f78584f55a76d570b5d68681765b/test/e2e/network/dual_stack.go#L115-L152

@wzshiming can you create a PR graduating the GA and removing the tag from the e2e test so we validate it runs and passes? , you'll have to trigger the dual stack job manually

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2024
@wzshiming
Copy link
Member Author

Thank you, I created the PR from your mention kubernetes/kubernetes#122870

thockin
thockin reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@wojtek-t wojtek-t self-assigned this Jan 31, 2024
@wojtek-t
Copy link
Member

Will take a look at PRR later this week.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2024

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wojtek-t, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0e0da28 into kubernetes:master Feb 2, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@wzshiming wzshiming deleted the kep-2681-ga branch February 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@thockin thockin thockin left review comments

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@thockin thockin

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@wzshiming @aojea @wojtek-t @k8s-ci-robot @thockin