Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2535:ensure secret pulled images - move kep targets; add persist #3532

Merged
merged 4 commits into from
Oct 5, 2023
Merged

#2535:ensure secret pulled images - move kep targets; add persist #3532

merged 4 commits into from
Oct 5, 2023

Conversation

mikebrow
Copy link
Member

Signed-off-by: Mike Brown brownwm@us.ibm.com

One-line PR description: bump kep release targets since the PR for the approved kep did not merge in time... and a request to do beta discussed persistence was made in review.
kubernetes/kubernetes#94899

Issue link: #2535

Other comments:
Merged kep.. #1608

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2022
@mikebrow mikebrow changed the title move kep targets; add persist #2535:ensure secret pulled images - move kep targets; add persist Sep 21, 2022
@mikebrow mikebrow mentioned this pull request Sep 21, 2022
Closed
4 tasks
@pacoxu
Copy link
Member

pacoxu commented Sep 21, 2022

I added it to https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#. However, I am not sure if this needs discussion in sig-node weekly meeting.

@rhockenbury rhockenbury mentioned this pull request Oct 1, 2022
Open
10 tasks
@pacoxu pacoxu mentioned this pull request Jan 5, 2023
Closed
4 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Jan 13, 2023

kubernetes/kubernetes#114847

After some simple testing and tries, I prefer to store it in a local file. And I will work on the PR later(I will have a Spring Festival holiday from Jan 18th to Jan 29th),

  • store in node status (need to be confirmed with sig-node): it needs API-change to add a list field like ensuredPulledImage in node status spec.
  • store in a local file like cpu policy state (should it be secured by an encryption scheme). [No API change, but a new file on every node.]
  • store in a secure volume? too complex to me?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Member Author

/reopen

@mikebrow
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot reopened this Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

@mikebrow: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Member

pacoxu commented Aug 29, 2023 •
edited
Loading

/assign @SergeyKanzhelev @mrunalp @dchen1107

Can we restart the review process in v1.29 release cycle?

@pacoxu
Copy link
Member

pacoxu commented Sep 14, 2023

IIRC, when we mentioned this by @mikebrow in the KEP planning SIG meeting, this KEP will be here to ensure things are as expected and it should not make any potential secret/permission leak.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@mikebrow
Copy link
Member Author

updated kep targets for v1.29 alpha

@pacoxu
Copy link
Member

pacoxu commented Sep 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@mikebrow
update for release 1.29
013a444 
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow mikebrow force-pushed the ensure-secret-pulled-images-persist branch from 5b089da to 013a444 Compare October 4, 2023 21:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikebrow, mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2023
@mikebrow
Copy link
Member Author

mikebrow commented Oct 5, 2023

/check-cla

@mikebrow mikebrow closed this Oct 5, 2023
@mikebrow mikebrow reopened this Oct 5, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 5, 2023
@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7ae1c1a into kubernetes:master Oct 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj requested changes

@ruiwen-zhao ruiwen-zhao ruiwen-zhao left review comments

@pacoxu pacoxu pacoxu approved these changes

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@pacoxu pacoxu

@ruiwen-zhao ruiwen-zhao

@dchen1107 dchen1107

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.