Welcome @drbugfinder-work!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @drbugfinder-work. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/assign @janetkuo
/assign @deads2k
/assign @cheftako

@liggitt
Thank you for constructive feedback and guidance for my first Kubernetes pull request.
I've tried to incorporate your feedback. I am looking forward to complete this feature with you.

Thanks for the updates. I'd recommend getting input from the sig-apps reviewers as well. I will have more time to look at this after the 1.19 code freeze.

@janetkuo
@mattfarina
@kow3ns
Do you have addition feedback regarding this proposal?
There wasn't any response to my mail to the sig-apps mailinglist:
https://groups.google.com/forum/#!topic/kubernetes-sig-apps/wWn3NzxXxDk

Are the last changes sufficient to get the pull request for this KEP accepted?

@janetkuo
Thank you for your feedback. I've changed the reviewers and approvers.

@drbugfinder-work we've added this KEP for discussion at the next SIG Apps meeting, Monday 15th 9am PT. See more details about the meetings here if you're able to join: https://github.com/kubernetes/community/tree/master/sig-apps#meetings.

Thanks for the updates. I'd recommend getting input from the sig-apps reviewers as well. I will have more time to look at this after the 1.19 code freeze.

@liggitt Hi Jordan,
Maybe you can have a look at this KEP, as 1.19 code freeze is over?
Thank you!

Hi @janetkuo, @mattfarina,
can you please tell me if this KEP is sufficient to be accepted?

@janetkuo @mattfarina is there any chance to get this or #1888 accepted?

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drbugfinder-work, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@drbugfinder-work thanks for addressing the comments and putting the KEP together!!!
@ahg-g I am volunteering to help you promote the KEP into implementable state

/lgtm

As discussed, we are going to merge this as provisional and continue the discussion in a new PR that aims to promote it to implementable. Notable things that needs works are: design details, in particular calling out that when pod-cost is set, the rank calculated by ReplicaSet is pod-cost then podsOnNode, when not set it will be just podsOnNode. The KEP also need to discuss whether or not this will be gated by a feature flag.

@drbugfinder-work can you please run ./hack/update-toc.sh and amend the change?

@ahg-g I've executed ./hack/update-toc.sh

@drbugfinder-work: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

/ok-to-test

@ahg-g I've executed ./hack/update-toc.sh

thanks, can you squash the two commits pls.

so I just learned about this:

/label tide/merge-method-squash

/lgtm

@drbugfinder-work thanks for addressing the comments and putting the KEP together!!!
@ahg-g I am volunteering to help you promote the KEP into implementable state

Thanks Jan, feel free to open a follow up PR. Lets try to get this done as soon as possible please.

@kgolab and I are working on a case that relates to this KEP. Relates to a preference to kill the oldest pod first which goes to the memory leaks occurring in a set of autoscaled replicas. The min set of replicas never change because they are always the oldest and as the result their performance degrades over time.
@kgolab to follow up
@josephburnett @koziorowski FYI

@kgolab and I are working on a case that relates to this KEP. Relates to a preference to kill the oldest pod first which goes to the memory leaks occurring in a set of autoscaled replicas. The min set of replicas never change because they are always the oldest and as the result their performance degrades over time.
@kgolab to follow up
@josephburnett @koziorowski FYI

@jforyciarz this should be easy to implement using a webhook. For example, you can define an annotation downscale-oldest-first, and use a webhook such that when downscale-oldest-first is set, it sets the pod-deletion-cost to -1*<current-timestamp> for example.