-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure policy for Jobs #298
Comments
Belated issue in the features repo but we have agreed on working on this in sig/apps for 1.7. @soltysh is OOO today so I am filling this out for him. |
This won't make it for 1.7, I'm removing the milestone. I'll be reworking this issue to be a single point of truth about all job-related enhancements and its current state. |
Currently being worked on by @clamoriniere1A (kubernetes/kubernetes#48075) |
/cc |
@clamoriniere1A @soltysh any updates for 1.8? Is this feature still on track for the release? |
@idvoretskyi kubernetes/kubernetes#48075 and kubernetes/kubernetes#51153 that implement this feature were merged 3days ago. |
@kow3ns there are several reasons this went straight to v1 and not beta or alike. First of all this can be seen more like a bigger bug fix (see kubernetes/kubernetes#27997) rather than a feature. Secondly, lots of users where pointing us that this is the most desirable extension of a job (see kubernetes/kubernetes#30243, kubernetes/kubernetes#43512, socialwifi/kubepy#18, https://twitter.com/b0rk/status/902627552195436547, as well as from talking to users during KubeCons), frequently mistaken with the restartPolicy on a pod template. |
@idvoretskyi yes it's already merged. I'll go ahead and close this issue in that case. |
@soltysh Can you please add the k8s.io Docs PR for this feature for 1.8 release here: https://docs.google.com/spreadsheets/d/1AFksRDgAt6BGA3OjRNIiO3IyKmA-GU7CXaxbihy48ns/edit#gid=0 |
@soltysh I'm not saying it shouldn't go in as is. It's just listed as alpha, but it will be enabled by default on the GA surface. So for the purposes of communication/documentation I don't see how we can call it an alpha feature. |
@soltysh I'll reopen the issue, we need it to keep open to track it. Thanks :) |
@kow3ns hmm... I see what you mean, now. Not sure how to answer it, though. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
This is already implemented. |
Update ControllerRef proposal
Feature Description
The text was updated successfully, but these errors were encountered: