Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure policy for Jobs #298

Closed
0xmichalis opened this issue May 5, 2017 · 16 comments
Closed

Failure policy for Jobs #298

0xmichalis opened this issue May 5, 2017 · 16 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@0xmichalis
Copy link

Feature Description

  • One-line feature description (can be used as a release note): Failure policy for Jobs
  • Primary contact (assignee): @soltysh
  • Responsible SIGs: @kubernetes/sig-apps-misc
  • Design proposal link (community repo): Backoff policy and failed pod limit community#583
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs): @erictune
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.7)
    • Beta release target (1.8)
@0xmichalis 0xmichalis added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label May 5, 2017
@0xmichalis
Copy link
Author

Belated issue in the features repo but we have agreed on working on this in sig/apps for 1.7. @soltysh is OOO today so I am filling this out for him.

kubernetes/community#583

@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 9, 2017
@idvoretskyi idvoretskyi added this to the v1.7 milestone May 9, 2017
@soltysh soltysh removed this from the v1.7 milestone Jun 8, 2017
@soltysh
Copy link
Contributor

soltysh commented Jun 8, 2017

This won't make it for 1.7, I'm removing the milestone. I'll be reworking this issue to be a single point of truth about all job-related enhancements and its current state.

@idvoretskyi
Copy link
Member

@soltysh @Kargakis any plans to make it for 1.8?

@0xmichalis
Copy link
Author

Currently being worked on by @clamoriniere1A (kubernetes/kubernetes#48075)

@idvoretskyi idvoretskyi added this to the 1.8 milestone Jul 25, 2017
@idvoretskyi idvoretskyi added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2017
@sdminonne
Copy link

/cc

@idvoretskyi
Copy link
Member

@clamoriniere1A @soltysh any updates for 1.8? Is this feature still on track for the release?

@clamoriniere1A
Copy link

clamoriniere1A commented Sep 5, 2017

@idvoretskyi kubernetes/kubernetes#48075 and kubernetes/kubernetes#51153 that implement this feature were merged 3days ago.

@kow3ns
Copy link
Member

kow3ns commented Sep 7, 2017

@soltysh @Kargakis this introduces a field into v1.Job, should we upgrade it to at least beta?

@soltysh
Copy link
Contributor

soltysh commented Sep 8, 2017

@kow3ns there are several reasons this went straight to v1 and not beta or alike. First of all this can be seen more like a bigger bug fix (see kubernetes/kubernetes#27997) rather than a feature. Secondly, lots of users where pointing us that this is the most desirable extension of a job (see kubernetes/kubernetes#30243, kubernetes/kubernetes#43512, socialwifi/kubepy#18, https://twitter.com/b0rk/status/902627552195436547, as well as from talking to users during KubeCons), frequently mistaken with the restartPolicy on a pod template.
Finally, I was hoping to change this feature issue to a general job feature describing the future extensions of a job scrambled all over the k8s issues, didn't get to it yet though :/ I think I'll just open a new one to track it properly.
I hope that clears your doubts.

@soltysh
Copy link
Contributor

soltysh commented Sep 8, 2017

@idvoretskyi yes it's already merged. I'll go ahead and close this issue in that case.

@soltysh soltysh closed this as completed Sep 8, 2017
@palak2011
Copy link

@soltysh Can you please add the k8s.io Docs PR for this feature for 1.8 release here: https://docs.google.com/spreadsheets/d/1AFksRDgAt6BGA3OjRNIiO3IyKmA-GU7CXaxbihy48ns/edit#gid=0

@kow3ns
Copy link
Member

kow3ns commented Sep 15, 2017

@soltysh I'm not saying it shouldn't go in as is. It's just listed as alpha, but it will be enabled by default on the GA surface. So for the purposes of communication/documentation I don't see how we can call it an alpha feature.

@idvoretskyi
Copy link
Member

@soltysh I'll reopen the issue, we need it to keep open to track it.

Thanks :)

@idvoretskyi idvoretskyi reopened this Sep 18, 2017
@soltysh
Copy link
Contributor

soltysh commented Sep 19, 2017

@kow3ns hmm... I see what you mean, now. Not sure how to answer it, though.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@soltysh
Copy link
Contributor

soltysh commented Jan 24, 2018

This is already implemented.
/close

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests

9 participants