Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node memory swap support #2400

Open
52 of 60 tasks
ehashman opened this issue Feb 1, 2021 · 159 comments
Open
52 of 60 tasks

Node memory swap support #2400

ehashman opened this issue Feb 1, 2021 · 159 comments
Assignees
@kannon92 @iholder101
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@ehashman
Copy link
Member

ehashman commented Feb 1, 2021 •
edited by pacoxu
Loading

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig node
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 1, 2021
@karan
Copy link

karan commented Feb 9, 2021

@cookieisaac

This was referenced Apr 6, 2021
Merged
Closed
@vasu1124 vasu1124 mentioned this issue Apr 12, 2021
Closed
@ehashman
Copy link
Member Author

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2021
@ehashman ehashman self-assigned this May 10, 2021
@jrsapi
Copy link

jrsapi commented May 11, 2021

Greetings @ehashman!
Enhancement shadow checking in with a few reminders. 1.22 Enhancements Freeze starts at 23:59:59 pst on Thursday, May 13. A few items needing review for this KEP:

Thanks!

@ehashman
Copy link
Member Author

All of this is covered in #2602

@jrsapi
Copy link

jrsapi commented May 13, 2021

Greetings @ehashman!
Thanks for the follow-up. After reviewing the KEP and PRR everything looks on target. The enhancement is marked at risk but once merged we can move its status to tracked. A reminder that tomorrow 5/13 the Enhancement freeze starts at 23:59:59 PST.

Thanks!

@ehashman
Copy link
Member Author

Work breakdown for 1.22

  • Documentation for enabling swap (TBD - @ehashman?)
  • CI environment/test updates (@ike-ma)
    • Build images with swap for 2 Linux distros
    • Add jobs to test-infra that use the images and enable the swap feature flag/kubelet option for node e2e suite
    • See also Test Plan
  • CRI and kubelet changes (@ehashman)
    • Complete API changes per KEP
    • Add e2e tests as appropriate

External to k8s but still need to happen:

  • Containerd update to use new CRI
  • CRI-O update to use new CRI

Once the above CRI updates happen, ensure that CI environment is using latest container runtimes with updated CRI.

@ike-ma ike-ma mentioned this issue Jun 7, 2021
Closed
@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @ehashman ,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you like the k/k PR/s that are needed to implement this enhancement for the 1.22 milestone?

@jrsapi
Copy link

jrsapi commented Jul 6, 2021

Greetings @ehashman,
A friendly reminder that code freeze is this Thursday, July 8th and we're tracking the following k/k PR:

Thanks!

@ehashman
Copy link
Member Author

ehashman commented Jul 7, 2021

PR just merged. Docs placeholder is kubernetes/website#28838

@jrsapi
Copy link

jrsapi commented Jul 7, 2021 •
edited
Loading

Awesome! Thanks for the update. Moving this to "Tracked".

@ehashman ehashman mentioned this issue Jul 8, 2021
Merged
@rajula96reddy rajula96reddy mentioned this issue Jul 19, 2021
Closed
1 task
@ehashman ehashman mentioned this issue Jul 20, 2021
Merged
@ehashman
Copy link
Member Author

We are good to go for 1.22! Docs complete.

@ehashman ehashman mentioned this issue Jul 26, 2021
Merged
@ehashman
Copy link
Member Author

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Aug 12, 2021
@ehashman
Copy link
Member Author

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jun 24, 2024
@SergeyKanzhelev
Copy link
Member

/unassign

@iholder101 iholder101 moved this from Triage to Proposed for consideration in SIG Node 1.32 KEPs planning Aug 20, 2024
@tjons
Copy link
Contributor

tjons commented Sep 15, 2024

Hello 👋 1.32 Enhancements Lead here,

I'm closing milestone 1.31 now,
If you have more work on this enhancement to complete in v1.32, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.32. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Sep 15, 2024
@iholder101
Copy link
Contributor

/milestone v1.32

@k8s-ci-robot
Copy link
Contributor

@iholder101: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iholder101 iholder101 mentioned this issue Sep 17, 2024
Open
@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 17, 2024
@hoerup
Copy link

hoerup commented Sep 18, 2024

Shouldn't this ticket be labeled with stage/stable ?

@pacoxu
Copy link
Member

pacoxu commented Sep 18, 2024

/stage stable
/remove-stage beta

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 18, 2024
@jenshu
Copy link

jenshu commented Sep 29, 2024

Hello @iholder101 @kannon92 @pacoxu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • In the KEP readme, can you please ensure that the Release Signoff Checklist section contains all the checkboxes from the latest template?
  • In the kep.yaml, the latest-milestone needs to be updated to v1.32
  • The PRR needs a line with the stage stable and an approver.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Sep 29, 2024
@jenshu
Copy link

jenshu commented Oct 11, 2024

Hello 👋, 1.32 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Oct 11, 2024
@jenshu jenshu moved this from At risk for enhancements freeze to Removed from Milestone in 1.32 Enhancements Tracking Oct 11, 2024
@pacoxu
Copy link
Member

pacoxu commented Oct 11, 2024

https://groups.google.com/d/msgid/kubernetes-sig-node/CA%2BoyvWYSqK_0T%2BUQTYNWTX9rNRWE9iOBjVpXffMW8pAu4ESnXg%40mail.gmail.com

  • An exception is open for this KEP.

@kannon92
Copy link
Contributor

We will keep this feature in beta and propose beta 3 for this with a focus on evictions.

kubernetes/kubernetes#128137

We also updated the KEP to reflect this new state so putting this here for clarity.

kiashok pushed a commit to kiashok/containerd-containerd that referenced this issue Oct 23, 2024
@mqasimsarfraz
cri: make swapping disabled with memory limit
0d8161d 
OCI runtime spec defines memory.swap as 'limit of memory+Swap usage'
so setting them to equal should disable the swap. Also, this change
should make containerd behaviour same as other runtimes e.g
'cri-dockerd/dockershim' and won't be impacted when user turn on
'NodeSwap' (kubernetes/enhancements#2400) feature.

Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
@tjons
Copy link
Contributor

tjons commented Oct 27, 2024

@kannon92 are there code changes for this KEP planned as part of beta 3?

@iholder101 iholder101 mentioned this issue Nov 19, 2024
Closed
8 tasks
@haircommander haircommander moved this from Considered for release to Removed in SIG Node 1.32 KEPs planning Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kannon92 kannon92

@iholder101 iholder101

Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
1.26 Enhancements Tracking
Status: Major Change
1.27 Enhancements Tracking
Status: Removed From Milestone
1.28 Enhancements Tracking
Status: Tracked
1.29 Enhancements Tracking
Status: Removed from Milestone
1.30 Enhancements Tracking
Status: Tracked for Doc Freeze
1.32 Enhancements Tracking
Status: Removed from Milestone
SIG Node 1.32 KEPs planning
Status: Removed
1.31 Enhancements Tracking
Status: Deferred
Milestone
No milestone
Development

No branches or pull requests