-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod attach/exec enhancements #2029
Comments
I think you are right. We probably should have some button to open terminal and when session is terminated or there is a timeout automatically close it. Refreshing the page would close the session and open a new one. |
FYI exec/attach should work w/ kubectl proxy after kubernetes/kubernetes#49534 gets merged. |
@ianlewis Great. |
@maciaszczykm Yah. Not sure if updating to use WebSockets is in scope of this issue or not though. |
A couple more issues for the list:
|
|
@floreks the second part never works, when it fails back to If |
This is related to incorrect session handling. Exec is in early stage and we are aware that there are some issues that make exec unusable for now. We are working on fixing them. It will be more stable in 1.7 release. |
Just FYI as this is relevant to this thread. I've started seeing the following message after upgrading dashboard to 1.7: Rolling back to 1.6.3 makes it possible again to execute bash while getting "connection closed" for shell-only pods. @maciaszczykm do want me to open a new issue for this? Or is it fine to collect such glitches under this umbrella issue? |
@kachkaev It is fine. Security was out piority 0 issue for 1.7 release, but now we should be able to find some time for issues like that. |
I am using the kops version of the dashboard in one of our environments and have taken this yaml: https://github.com/kubernetes/kops/blob/master/addons/kubernetes-dashboard/v1.7.0.yaml, just updated the dashboard image to 1.7.1 and still seeing the 'Connection closed' issue if the pod does not have bash. I have confirmed in the About section that it really is 1.7.1 and interestingly enough in our other cluster where we are using the recommended yaml from the repo here it all works fine. |
They differ a bit :) Very important part is missing in your yaml file. volumeMounts:
- name: kubernetes-dashboard-certs
mountPath: /certs
readOnly: true
# Create on-disk volume to store exec logs
- mountPath: /tmp
name: tmp-volume
livenessProbe:
httpGet:
scheme: HTTPS
path: /
port: 8443
initialDelaySeconds: 30
timeoutSeconds: 30
volumes:
- name: kubernetes-dashboard-certs
secret:
secretName: kubernetes-dashboard-certs
- name: tmp-volume
emptyDir: {} |
@floreks Thanks for that snippet - the kops deployment is also just accessible via https and is using its own cert. It even provides a shortcut url
Should this then be a new issue here, or is that more kops responsibility? |
/ui redirect has not been updated yet and points to wrong scheme (http instead of https). Check links provided in README or Accessing Guide on our wiki pages. There are correct links provided. |
@Globegitter You can check current status at #2395 and in referenced issues. |
@floreks Is there a ticket or line-item tracking this: "when it fails back to /bin/sh the console closes right after shell started." I'm still experiencing the crash every time with |
it is still crashes.
|
If you have used some custom yaml to deploy it then it might. We are explicitly creating |
Thank you it works for me! Crash does not happend! |
@floreks Currently , the dashboard version is v1.7.1 in my environment, I found that if the command '/bin/bash' does not exists in another container, I can't login into that container from dashboard. |
Moved task list from #1939 to an issue to keep track of them:
/bin/ash
,cmd.exe
(Feature Request: Exec /bin/ash (for alpine images) #2305, Dashboard "exec" should run cmd.exe on Windows pods instead of bash #2888)The text was updated successfully, but these errors were encountered: