Add section on reviewing/approving godeps #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
approved
spiffxp
reviewed
Feb 16, 2018
contributors/devel/godep.md
Outdated
| project? | ||
|
|
||
| All new dependency licenses should be reviewed by either Tim Hockin (@thockin) | ||
| or the Steering Committee to ensure that they are compatible with the Kubernetes |
There was a problem hiding this comment.
Steering Committee (@kubernetes/steering-committee)
cblecker
force-pushed
the
godeps-owners
branch
from
36a9bef to
0b774ed
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add section to godeps doc talking about the procedure to review/approve dependency changes.
/assign @thockin