Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase addon-resizer to distroless #1882

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Rebase addon-resizer to distroless #1882

merged 1 commit into from
Apr 14, 2019

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Apr 11, 2019

This is part of the effort described in KEP kubernetes/enhancements#900
This mitigates the affect of GVE issues.

@yuwenma
Rebase addon-resizer to distroless
1a3670f 
This is part of the effort described in KEP kubernetes/enhancements#900
This mitigates the affect of GVE issues.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented Apr 11, 2019

/assign @bskiba
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot requested review from bskiba and wojtek-t April 11, 2019 22:54
mwielgus
mwielgus reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have support for all the removed architectures in distroless?

@yuwenma
Copy link
Contributor Author

yuwenma commented Apr 13, 2019

Do we have support for all the removed architectures in distroless?

Great question. Just double checked with Tim Allstair and we should be good.
See this for detail

mwielgus
mwielgus approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit df0c4bf into kubernetes:master Apr 14, 2019
@bskiba
Copy link
Member

bskiba commented Apr 16, 2019

@yuwenma Sorry to be late to the party, but addon-resizer still uses glog, won't this be an issue?

@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@bskiba bskiba Awaiting requested review from bskiba

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@bskiba bskiba

@wojtek-t wojtek-t

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuwenma @k8s-ci-robot @bskiba @mwielgus @wojtek-t