Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to k8c.io/machine-controller #413

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update to k8c.io/machine-controller #413

merged 1 commit into from
Aug 26, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 26, 2024

What this PR does / why we need it:

machine-controller module has been moved to k8c.io/machine-controller (kubermatic/machine-controller#1842), this PR updates OSM to reflect this.

What type of PR is this?

/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

/assign @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@xmudrii
Update to k8c.io/machine-controller
9a96d62 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fce54b488c476b8ec6d30d0927c48a9726f713d2

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@kubermatic-bot kubermatic-bot merged commit 0576dcc into kubermatic:main Aug 26, 2024
11 checks passed
@xmudrii xmudrii deleted the k8c-io-mc branch August 26, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik