Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node synthetic ref #108

Merged
merged 10 commits into from
Dec 23, 2022
Merged

Implement node synthetic ref #108

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
da7114e
Implement node synthetic ref
vassilvk Dec 11, 2022
5067bf1
Clarify target object in error message
vassilvk Dec 12, 2022
0994f92
Enable building on mac using go 1.18
vassilvk Dec 12, 2022
a2100ee
Update sample deployment
vassilvk Dec 14, 2022
1ac5ab5
Merge master into topic branch
vassilvk Dec 16, 2022
bf5c4a1
Implement unit test for node ref data
vassilvk Dec 23, 2022
ae49795
Add note about node synthetic refs
vassilvk Dec 23, 2022
e2ab406
Update README
vassilvk Dec 23, 2022
ec1f691
Make patch sorting stable
vassilvk Dec 23, 2022
f77d6ad
Update README
vassilvk Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make patch sorting stable
  • Loading branch information
@vassilvk
vassilvk committed Dec 23, 2022
commit ec1f6915930e8c2a7f2d3efcb15747ef68ea1d45
6 changes: 6 additions & 0 deletions core/dragnetwebhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"context"
"io/ioutil"
"path"
"sort"

"github.com/golang/mock/gomock"
"github.com/kubemod/kubemod/api/v1beta1"
Expand Down Expand Up @@ -108,6 +109,11 @@ var _ = Describe("DragnetWebhookHandler", func() {

Expect(len(response.Patches)).To(Equal(2))

// Sort the patch because the order returned by CalculatePatch is unstable.
sort.SliceStable(response.Patches, func(i, j int) bool {
return (response.Patches[i].Operation + response.Patches[i].Path) < (response.Patches[j].Operation + response.Patches[j].Path)
})

Expect(response.Patches[0].Operation).To(Equal("add"))
Expect(response.Patches[0].Path).To(Equal("/metadata/labels/topology.kubernetes.io~1region"))
Expect(response.Patches[0].Value).To(Equal("us-west-2"))
Expand Down