Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build, add Glide for dependency management. #8

Merged
merged 6 commits into from
Jul 31, 2017
Merged

Fix build, add Glide for dependency management. #8

merged 6 commits into from
Jul 31, 2017

Conversation

wbuchwalter
Copy link
Contributor

@wbuchwalter wbuchwalter commented Jul 30, 2017

Related to https://github.com/jlewi/mlkube.io/issues/7.
PR to illustrate what using glide would look like.
If you would rather user dep or godep, let me know and I'll change the PR.

The diff is quite large because some files in the project were using 2 spaces as indentations, other were using tabs, my editor reformatted everything to use 2 spaces everywhere.

Important changes are addition of glide.yaml, glide.lock and fixing some imports.

@wbuchwalter wbuchwalter changed the title Fix build, and add Glide for dependency managemnt. Fix build, and add Glide for dependency management. Jul 30, 2017
@wbuchwalter wbuchwalter changed the title Fix build, and add Glide for dependency management. Fix build, add Glide for dependency management. Jul 31, 2017
@jlewi
Copy link
Contributor

jlewi commented Jul 31, 2017

Thanks for doing this!

Overall looks good, but could you reformat or the files with gofmt and recompute the diff against master?

I just reformatted all the code on master with gofmt. So if you do the same, most of the whitespace and other formatting changes will go away and it will be easier to review.

I apologize for not doing this sooner.

It looks like gofmt uses tabs not spaces so lets follow that if you don't mind.

@wbuchwalter
Copy link
Contributor Author

@jlewi Done :)

@jlewi
Copy link
Contributor

jlewi commented Jul 31, 2017

LGTM.

Thank you.

@jlewi jlewi merged commit 4bd9c08 into kubeflow:master Jul 31, 2017
@wbuchwalter wbuchwalter mentioned this pull request Jul 31, 2017
ChenYi015 pushed a commit to ChenYi015/training-operator that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants