feat(group): Update CRD group to kubeflow.org #354
Conversation
Signed-off-by: Ce Gao <ce.gao@outlook.com>
|
Hi @gaocegege. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for doing this! |
|
Thanks and I will fix it soon. |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
|
PTAL @jlewi |
| @@ -34,27 +34,27 @@ type TFJobLister interface { | |||
| TFJobListerExpansion | |||
| } | |||
|
|
|||
| // tfJobLister implements the TFJobLister interface. | |||
| type tfJobLister struct { | |||
| // tFJobLister implements the TFJobLister interface. | |||
There was a problem hiding this comment.
Why did you change the capitalization to "tFJobLister" this looks strange to me; I prefer tfJobLister. Since we decided on TFJob (i.e capitalizing TF) i think it makes sense to make both T & F lower case for non public variables.
There was a problem hiding this comment.
Either way if you do think the capitalization should be changed lets discuss in a different PR. Since this PR touches so many files it would be good to get it in soon.
There was a problem hiding this comment.
This is auto-changed by ./hack/update-codegen.sh, I will try to update it.
There was a problem hiding this comment.
I think we should not change the code in client/ manually since it will be overrode next time we run the script, and the name is changed to tF since the job is renamed from TfJob to TFJob. #332
There was a problem hiding this comment.
You're right. I didn't realize this was autogenerated.
|
/ok-to-test |
jlewi
changed the title
Close #337
Signed-off-by: Ce Gao ce.gao@outlook.com
This change is