Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.7 in v1.2 branch #1383

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Aug 27, 2021

Fixes #1306

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

go.mod Outdated
github.com/google/go-cmp v0.4.1 // indirect
github.com/kubeflow/common v0.3.3
github.com/go-openapi/spec v0.20.3
github.com/kubeflow/common v0.3.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix volcano issue and release a 0.3.7 version to use?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this done first.

@Jeffwan
Copy link
Member

Jeffwan commented Aug 29, 2021

/test kubeflow-tf-operator-presubmit

@gaocegege gaocegege changed the title fix(operator): Update k8s related package to 0.19.9, kubeflow/common to 0.3.6 chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.6 Aug 30, 2021
@gaocegege gaocegege changed the title chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.6 chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.6 in v1.2 branch Aug 30, 2021
@Jeffwan
Copy link
Member

Jeffwan commented Aug 31, 2021

Let's bump to 0.3.7 directly. #1388

@gaocegege
Copy link
Member Author

OK I will update the PR.

@gaocegege gaocegege force-pushed the common branch 2 times, most recently from aefbda6 to e6a0caa Compare August 31, 2021 03:32
@Jeffwan Jeffwan changed the title chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.6 in v1.2 branch chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.7 in v1.2 branch Aug 31, 2021
@Jeffwan
Copy link
Member

Jeffwan commented Aug 31, 2021

/lgtm
/approve

@Jeffwan
Copy link
Member

Jeffwan commented Aug 31, 2021

@gaocegege there's a conflicting file. Interesting. no one merges codes to v1.2-branch

gaocegege and others added 2 commits August 31, 2021 14:29
Signed-off-by: Ce Gao <gaocegege@hotmail.com>
Signed-off-by: cegao <cegao@tencent.com>
@gaocegege
Copy link
Member Author

Because 3c20785 updates the go mod as well.

@gaocegege
Copy link
Member Author

/cc @Jeffwan

@Jeffwan
Copy link
Member

Jeffwan commented Aug 31, 2021

/lgtm
/approve

@Jeffwan
Copy link
Member

Jeffwan commented Aug 31, 2021

/cc @johnugeorge @gaocegege I can not approve this branch. Please help approve it

@gaocegege
Copy link
Member Author

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 7e4e435 into kubeflow:v1.2-branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants