-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update k8s related package to 0.19.9, kubeflow/common to 0.3.7 in v1.2 branch #1383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
go.mod
Outdated
github.com/google/go-cmp v0.4.1 // indirect | ||
github.com/kubeflow/common v0.3.3 | ||
github.com/go-openapi/spec v0.20.3 | ||
github.com/kubeflow/common v0.3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fix volcano issue and release a 0.3.7 version to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this done first.
/test kubeflow-tf-operator-presubmit |
Let's bump to 0.3.7 directly. #1388 |
OK I will update the PR. |
aefbda6
to
e6a0caa
Compare
/lgtm |
@gaocegege there's a conflicting file. Interesting. no one merges codes to v1.2-branch |
Signed-off-by: Ce Gao <gaocegege@hotmail.com>
Signed-off-by: cegao <cegao@tencent.com>
Because 3c20785 updates the go mod as well. |
/cc @Jeffwan |
/lgtm |
/cc @johnugeorge @gaocegege I can not approve this branch. Please help approve it |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, Jeffwan, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1306