Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go test to CI #1436

Closed
tenzen-y opened this issue Oct 6, 2021 · 3 comments · Fixed by #1440
Closed

Add Go test to CI #1436

tenzen-y opened this issue Oct 6, 2021 · 3 comments · Fixed by #1440
Assignees
@tenzen-y
Labels
kind/feature

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Oct 6, 2021

/kind feature

I think this repository is not running any tests for Go in CI. So, I'd like to add CI to run the test for Go same as Katib using GitHub actions.
Does it sound good? @kubeflow/wg-training-leads

coveralls

travis
@andreyvelich
Copy link
Member

andreyvelich commented Oct 6, 2021 •
edited
Loading

That will be great, thank you @tenzen-y!
What do you think @Jeffwan ?
Corresponding issue: #1311.

@Jeffwan
Copy link
Member

Jeffwan commented Oct 6, 2021

For unit test etc, we can use separate CI. We used to have it in pipeline but it got removed earlier. @tenzen-y thanks for the help

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 7, 2021 •
edited
Loading

Thanks for your comments! @andreyvelich @Jeffwan
I'd like to work on this issue.

@tenzen-y tenzen-y mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenzen-y tenzen-y

Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CI to run the tests for Go tenzen-y/training-operator
4 participants
@Jeffwan @andreyvelich @google-oss-robot @tenzen-y