remove subpackage vendor (#222)

Add the vendor directory to the repository. * Checking in vendor is a common convention. For example, a variety of projects in kubernetes check in vendor. * This should help developers by allowing them to skip updating the deps and doing the manual step of fixing some of the dependencies. * remove subpackage vendor from .gitignore Examples of checking in vendor https://github.com/kubernetes/kubernetes https://github.com/kubernetes/client-go/tree/master/vendor https://github.com/ksonnet/ksonnet https://github.com/kubernetes/test-infra Some counter examples https://github.com/grpc/grpc-go https://github.com/GoogleCloudPlatform/google-cloud-go https://github.com/google/glog https://github.com/kubernetes/helm It looks like our total repo size is ~125 MB and ~110 MB of this vendor. But you have to download all 125 MB if you want to fully build it; so a smaller repo size doesn't really make cloning and building the code any faster. So following the K8s convention and checking in vendor makes sense.
kubeflow · Dec 18, 2017 · c8bcb9d · c8bcb9d
1 parent eb0fd5f
commit c8bcb9d
Show file tree

Hide file tree

Showing 5,275 changed files with 2,302,994 additions and 17 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,7 +1,6 @@
 # pkg and bin directories currently contain build artifacts
 # only so we exclude them.
 bin/
-vendor/
 
 .vscode/
 

diff --git a/developer_guide.md b/developer_guide.md
@@ -11,15 +11,11 @@ ln -sf ${GIT_TRAINING} ${GOPATH}/src/github.com/tensorflow/k8s
 
 Resolve dependencies (if you don't have glide install, check how to do it [here](https://github.com/Masterminds/glide/blob/master/README.md#install))
 
+install dependencies, `-v` will ignore subpackage vendor
 ```sh
-glide install
-rm -rf  vendor/k8s.io/apiextensions-apiserver/vendor
+glide install -v
 ```
 
-  * The **rm** is needed to remove the vendor directory of dependencies
-    that also vendor dependencies as these produce conflicts
-    with the versions vendored by mlkube
-
 Build it
 
 ```sh

diff --git a/glide.lock b/glide.lock
diff --git a/vendor/cloud.google.com/go/.travis.yml b/vendor/cloud.google.com/go/.travis.yml
diff --git a/vendor/cloud.google.com/go/AUTHORS b/vendor/cloud.google.com/go/AUTHORS
diff --git a/vendor/cloud.google.com/go/CONTRIBUTING.md b/vendor/cloud.google.com/go/CONTRIBUTING.md
diff --git a/vendor/cloud.google.com/go/CONTRIBUTORS b/vendor/cloud.google.com/go/CONTRIBUTORS