Skip to content

Commit

Permalink
Fix XGBoost container name in log message (#1362)
Browse files Browse the repository at this point in the history
  • Loading branch information
andreyvelich authored Aug 14, 2021
1 parent 52cddec commit 08c0d03
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/apis/xgboost/validation/validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import (
xgboostv1 "github.com/kubeflow/tf-operator/pkg/apis/xgboost/v1"

commonv1 "github.com/kubeflow/common/pkg/apis/common/v1"

torchv1 "github.com/kubeflow/tf-operator/pkg/apis/pytorch/v1"
)

func ValidateV1XGBoostJobSpec(c *xgboostv1.XGBoostJobSpec) error {
Expand Down Expand Up @@ -59,9 +57,9 @@ func ValidateV1XGBoostJobSpec(c *xgboostv1.XGBoostJobSpec) error {
defaultContainerPresent = true
}
}
//Make sure there has at least one container named "pytorch"
//Make sure there has at least one container named "xgboost"
if !defaultContainerPresent {
msg := fmt.Sprintf("XGBoostReplicaType is not valid: There is no container named %s in %v", torchv1.DefaultContainerName, rType)
msg := fmt.Sprintf("XGBoostReplicaType is not valid: There is no container named %s in %v", xgboostv1.DefaultContainerName, rType)
return fmt.Errorf(msg)
}
if rType == xgboostv1.XGBoostReplicaTypeMaster {
Expand Down

0 comments on commit 08c0d03

Please sign in to comment.