Skip to content

Files modified in PR not computed correctly because clone depth = 1 #473

Closed
@jlewi

Description

kubeflow/kubeflow#4148

Is an example where we incorrectly detected the files that were changed in the PR.
We ended up including files which had been modified on master after the commit on which the PR was based.

The command

 git merge-base HEAD remotes/origin/master 

failed so we ended up computing a diff against master.

It looks like we are cloning with depth = 2

git clone --depth=2 --no-single-branch https://github.com/${REPO_OWNER}/${REPO_NAME}.git ${SRC_DIR}/${REPO_OWNER}/${REPO_NAME}

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions