Create a python script to deploy Kubeflow on GCP via deployment manager. #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlewi
changed the title
|
/retest |
testing/deploy_kubeflow_gcp.py
Outdated
| test_suite.run() | ||
|
|
||
| if __name__ == "__main__": | ||
| logging.basicConfig( |
There was a problem hiding this comment.
test_helper.init() takes care of logging initialization
https://github.com/kubeflow/testing/blob/master/py/kubeflow/testing/test_helper.py#L159
| @@ -0,0 +1,4 @@ | |||
| INFO|2018-05-23T18:14:50|deploy_kubeflow_gcp.py:118| Creating deployment jlewi-kubeflow-test3 in project cloud-ml-dev | |||
There was a problem hiding this comment.
Checked in by accident?
|
Most recent failure was a flake in gke_e2e trying to contact github.com |
|
Test flake looks unrelated So I think this is ready for review. |
jlewi
changed the title
|
/assign @kunmingg |
|
/retest |
|
More random test failures |
|
/retest |
…nager. * The scripts replaces our bash commands * For teardown we want to add retries to better handle INTERNAL_ERRORS with deployment manager that are causing the test to be flaky. Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager. * Fix resource_not_found errors in delete (kubeflow#833) * The not found error was due to the type providers for K8s resources being deleted before the corresponding K8s resources. So the subsequent delete of the K8s resource would fail because the type provider did not exist. * We fix this by using a $ref to refer to the type provider in the type field of K8s resources.
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Timed out waiting for TfJob ; everything else passed. The workflow logs indicate the TFJob started and entered the running state pretty quickly. But then it appears to have gotten stuck. I looked at the Kubernetes events related to this name space and it looks like most of the pods Master starts and is stuck waiting for But the pod logs for that pod indicated it started just fine. |
|
/retest |
This was referenced May 25, 2018
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test all |
|
/lgtm |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…er. (kubeflow#866) * Create python scripts for deploying Kubeflow on GCP via deployment manager. * The scripts replaces our bash commands * For teardown we want to add retries to better handle INTERNAL_ERRORS with deployment manager that are causing the test to be flaky. Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager. * Fix resource_not_found errors in delete (kubeflow#833) * The not found error was due to the type providers for K8s resources being deleted before the corresponding K8s resources. So the subsequent delete of the K8s resource would fail because the type provider did not exist. * We fix this by using a $ref to refer to the type provider in the type field of K8s resources. * * deletePolicy can't be set per resource * Autoformat jsonnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with deployment manager that are causing the test to be flaky.
Related to #836 verify Kubeflow deployed correctly with deployment manager.
Fix resource_not_found errors in delete (GCP deployment manager test handle internal errors #833)
The not found error was due to the type providers for K8s resources
being deleted before the corresponding K8s resources. So the subsequent
delete of the K8s resource would fail because the type provider did not
exist.
We fix this by using a $ref to refer to the type provider in the type field
of K8s resources.
This change is