Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update k8s #7660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update k8s #7660

wants to merge 1 commit into from

Conversation

hiramf
Copy link

@hiramf hiramf commented Nov 15, 2024 •
edited
Loading

In order to support native sidecar containers (introduced in kubernetes v1.28), we need to update this API.

Current error when trying to set a restart policy:

strict decoding error: unknown field "spec.initContainers[0].restartPolicy"

Links:

@hiramf
update k8s
b409c59 
Signed-off-by: Hiram Foster <hiramfoster.co@gmail.com>
@google-oss-prow google-oss-prow bot requested a review from kimwnasptd November 15, 2024 20:18
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hiramf