Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support selector.matchExpression in PodDefaults #7551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boarder7395
Copy link
Contributor

This PR is to fix issue kubeflow/notebooks#99.

Poddefaults support matchExpressions, but the logic for /api/namespaces//poddefaults fails when the matchExpressions field is used in place of matchLabels. This approach updates the label name using the matchExpression key.

@google-oss-prow google-oss-prow bot requested a review from kimwnasptd April 15, 2024 16:07
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ca-scribner
Copy link
Contributor

I hit this bug today too, but I think the issue is slightly different (details in kubeflow/notebooks#121). Rather than handle both matchLabels and matchExpressions, I believe the label returned here is probably supposed to be the name of the PodDefault, not the first selector in the list

Signed-off-by: Tyler Kalbach <tkalbach@athenahealth.com>
@thesuperzapper thesuperzapper changed the title Add logic to handle when poddefaults use matchExpression feat: support selector.matchExpression in PodDefaults Jun 11, 2024
@thesuperzapper thesuperzapper added this to the v1.9.1 milestone Jun 11, 2024
@wjhhuizi
Copy link

wjhhuizi commented Jul 2, 2024

Just adding some more information here:

The matchExpressions is actually working, but the UI/API does not support it.

API: https://<hostname>/jupyter/api/namespaces/<namespace>/poddefaults

{
    "log": "An error occured in the backend.",
    "status": 500,
    "success": false,
    "user": "<Email@Address>"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants