Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show error logs for YAML parsing in notebooks ui #7497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: show error logs for YAML parsing in notebooks ui #7497

wants to merge 1 commit into from

Conversation

t-k
Copy link

@t-k t-k commented Mar 4, 2024

Currently, when a YAML parsing error occurs in load_yaml and load_param_yaml, no error log is output.

This is useful for troubleshooting problems such as when spawner_ui_config.yaml is not reflected.

@t-k
Add error log for YAML parsing
1846472 
- Added logging of error details when encountering a YAML parsing error.
- This provides more context and information for troubleshooting issues.

Signed-off-by: Tatsuo Kaniwa <tatsuo@kaniwa.biz>
@google-cla Google CLA
Copy link

google-cla bot commented Mar 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper thesuperzapper added this to the v1.9.1 milestone May 13, 2024
@thesuperzapper thesuperzapper changed the title Add error log for YAML parsing fix: show error logs for YAML parsing in notebooks ui May 13, 2024
@thesuperzapper thesuperzapper mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
v1.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@t-k @thesuperzapper