Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profile-controller): propagate labels from CR to namespace #7481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(profile-controller): propagate labels from CR to namespace #7481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(profile-controller): propagate labels from CR to namespace 
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: jsonmp-k8 <paul.jaison@gmail.com>
Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
Co-authored-by: moorthy156 <narayanamoorthy.mari@gmail.com>
  • Loading branch information
@droctothorpe @jsonmp-k8
@tarat44 @moorthy156
4 people committed Feb 23, 2024
commit e2e8780ec8cddaab2722a7e8422cf4aaf12eb808
1 change: 1 addition & 0 deletions components/profile-controller/controllers/profile_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ func (r *ProfileReconciler) Reconcile(ctx context.Context, request ctrl.Request)
},
}
setNamespaceLabels(ns, defaultKubeflowNamespaceLabels)
setNamespaceLabels(ns, instance.ObjectMeta.Labels)
logger.Info("List of labels to be added to namespace", "labels", ns.Labels)
if err := controllerutil.SetControllerReference(instance, ns, r.Scheme); err != nil {
IncRequestErrorCounter("error setting ControllerReference", SEVERITY_MAJOR)
Expand Down