Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo when setting server_type for jupyter notebook (no in app affect) #6666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: typo when setting server_type for jupyter notebook (no in app affect) #6666

wants to merge 1 commit into from

Conversation

johnhoman
Copy link
Contributor

I'm fairly certain this is a typo

@google-cla
Copy link

google-cla bot commented Oct 5, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval by writing /assign @kimwnasptd in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

@johnhoman I agree that this is a typo, since it's a very small fix I am ok with merging. Either way, are you aware of any direct effects of this problem?

/lgtm

/assign @kimwnasptd

@google-oss-prow google-oss-prow bot added the lgtm label Oct 18, 2022
@johnhoman
Copy link
Contributor Author

@johnhoman I agree that this is a typo, since it's a very small fix I am ok with merging. Either way, are you aware of any direct effects of this problem?

/lgtm

/assign @kimwnasptd

I haven't noticed anything break from this. I just happen to notice it while I was reading through the code

@thesuperzapper thesuperzapper changed the title jupyter web app set default server_type fix: typo when setting server_type for jupyter notebook (no in app affect) May 13, 2024
@thesuperzapper thesuperzapper added this to the v1.9.1 milestone May 13, 2024
@thesuperzapper thesuperzapper mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elikatsis elikatsis Awaiting requested review from elikatsis

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees

@thesuperzapper thesuperzapper

@kimwnasptd kimwnasptd

Labels
lgtm size/XS
Projects
None yet
Milestone
v1.9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@johnhoman @thesuperzapper @kimwnasptd