Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '--reload_multifile' argument to tensorboard #6538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add '--reload_multifile' argument to tensorboard #6538

wants to merge 1 commit into from

Conversation

AppleHolic
Copy link

  • Problem
    If the log directory has several event files, tensorboard could not load all logs immediately.

  • Solution
    The "--reload_multifile" argument can be used to poll all "active" files in a directory for new data, rather than the most recent one as mentioned at related docs of tensorboard repository. All of the logs are loaded well after applying that argument.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimwnasptd
Copy link
Member

Thanks for the PR @AppleHolic!

I have two comments:

  1. Can you add a TB_RELOAD_MULTIFILE flag and use that for setting the --reload_multifile. You can take an example of a similar true/false flag in https://github.com/kubeflow/kubeflow/blob/master/components/notebook-controller/pkg/culler/culler.go#L28
  2. Can you rebase on top of the latest master? We have introduced some GH actions that I see are not triggered

@juliusvonkohout
Copy link
Member

Can you join the next notebooks WG meeting in two weeks ? We are always looking for help.

https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars has the calendar and meeting notes.

You can also reach us on slack in the channel wg-notebooks and wg-manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elikatsis elikatsis Awaiting requested review from elikatsis

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AppleHolic @kimwnasptd @juliusvonkohout