-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update user_guide #646
update user_guide #646
Conversation
Do we have a good link for the minimum auth setup required? |
user_guide.md
Outdated
@@ -322,6 +322,10 @@ inception LoadBalancer 10.35.255.136 ww.xx.yy.zz 9000:30936/TCP 28m | |||
|
|||
In this example, you should be able to use the inception_client to hit ww.xx.yy.zz:9000 | |||
|
|||
The model at gs://kubeflow-models/inception is public accessible. However, if your environment doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publicly
user_guide.md
Outdated
@@ -322,6 +322,10 @@ inception LoadBalancer 10.35.255.136 ww.xx.yy.zz 9000:30936/TCP 28m | |||
|
|||
In this example, you should be able to use the inception_client to hit ww.xx.yy.zz:9000 | |||
|
|||
The model at gs://kubeflow-models/inception is public accessible. However, if your environment doesn't | |||
have google authentication setup, TF serving will have problem reading the model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a link to what it means to have GCP credentials?
"TF serving will not be able to read the model"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: same as above "publicly"
Added more explanation and a link. PTAL, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, would be written "Google Cloud credentials" but I'm sure we'll be back in here soon for something else. ;-)
Thanks @lluunn !
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update md * address comment
* Show only succeeded trials * Create build
* update profile image * update test * update metadata test as well
The inception model on GCS should be public, but some user might run into problem reading it.
Fix #621
/cc @jlewi
This change is