Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user_guide #646

Merged
merged 2 commits into from
Apr 15, 2018
Merged

update user_guide #646

merged 2 commits into from
Apr 15, 2018

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Apr 11, 2018

The inception model on GCS should be public, but some user might run into problem reading it.

Fix #621
/cc @jlewi


This change is Reviewable

@pdmack
Copy link
Member

pdmack commented Apr 12, 2018

Do we have a good link for the minimum auth setup required?
This?

user_guide.md Outdated
@@ -322,6 +322,10 @@ inception LoadBalancer 10.35.255.136 ww.xx.yy.zz 9000:30936/TCP 28m

In this example, you should be able to use the inception_client to hit ww.xx.yy.zz:9000

The model at gs://kubeflow-models/inception is public accessible. However, if your environment doesn't
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicly

user_guide.md Outdated
@@ -322,6 +322,10 @@ inception LoadBalancer 10.35.255.136 ww.xx.yy.zz 9000:30936/TCP 28m

In this example, you should be able to use the inception_client to hit ww.xx.yy.zz:9000

The model at gs://kubeflow-models/inception is public accessible. However, if your environment doesn't
have google authentication setup, TF serving will have problem reading the model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link to what it means to have GCP credentials?
"TF serving will not be able to read the model"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: same as above "publicly"

@lluunn
Copy link
Contributor Author

lluunn commented Apr 14, 2018

Added more explanation and a link. PTAL, thanks

Copy link
Member

@pdmack pdmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, would be written "Google Cloud credentials" but I'm sure we'll be back in here soon for something else. ;-)
Thanks @lluunn !
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be8ed83 into kubeflow:master Apr 15, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* update md

* address comment
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Show only succeeded trials

* Create build
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* update profile image

* update test

* update metadata test as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants