Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission-webhook: Consolidate manifests #5719

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ spec:
- mountPath: /etc/webhook/certs
name: webhook-cert
readOnly: true
ports:
- name: https-webhook
containerPort: 4443
volumes:
- name: webhook-cert
secret:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,15 @@ resources:
- service.yaml
- crd.yaml
commonLabels:
app: admission-webhook
kustomize.component: admission-webhook
namePrefix: admission-webhook-
app: poddefaults
kustomize.component: poddefaults
app.kubernetes.io/component: poddefaults
app.kubernetes.io/name: poddefaults
images:
- name: gcr.io/kubeflow-images-public/admission-webhook
newName: gcr.io/kubeflow-images-public/admission-webhook
newTag: vmaster-ge5452b6f
namespace: kubeflow
configMapGenerator:
- envs:
- params.env
name: admission-webhook-parameters
generatorOptions:
disableNameSuffixHash: true
vars:
Expand All @@ -31,12 +28,12 @@ vars:
# We need the var names to be relatively unique so that when we
# compose with other applications they won't conflict.
- fieldref:
fieldPath: data.namespace
fieldPath: metadata.namespace
name: podDefaultsNamespace
objref:
apiVersion: v1
kind: ConfigMap
name: admission-webhook-parameters
kind: Service
name: service
- fieldref:
fieldPath: metadata.name
name: podDefaultsServiceName
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ webhooks:
- clientConfig:
caBundle: ""
service:
name: $(podDefaultsServiceName)
namespace: $(podDefaultsNamespace)
name: service
path: /apply-poddefault
name: $(podDefaultsDeploymentName).kubeflow.org
namespaceSelector:
Expand Down
19 changes: 19 additions & 0 deletions components/admission-webhook/manifests/base/params.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
varReference:
- path: webhooks/clientConfig/service/namespace
kind: MutatingWebhookConfiguration
- path: webhooks/clientConfig/service/name
kind: MutatingWebhookConfiguration
- path: webhooks/name
kind: MutatingWebhookConfiguration
nameReference:
- kind: Service
version: v1
fieldSpecs:
- kind: MutatingWebhookConfiguration
group: admissionregistration.k8s.io
path: webhooks/clientConfig/service/name
namespace:
- kind: MutatingWebhookConfiguration
group: admissionregistration.k8s.io
path: webhooks/clientConfig/service/namespace
create: true
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ metadata:
name: service
spec:
ports:
- port: 443
targetPort: 4443
- name: https-webhook
port: 443
targetPort: https-webhook

This file was deleted.

This file was deleted.

131 changes: 0 additions & 131 deletions components/admission-webhook/manifests/bootstrap/base/config-map.yaml

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading