admission-webhook: Consolidate manifests #5719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Umbrella-Issue: kubeflow/manifests#1769
PodDefaults Webhook
Current manifests structure
Explanation
bootstrap
is a custom solution for creating a cert for the poddefaults webhook. I can't find the code for that solution in this repo. Instead of maintaining such code, we should rely on cert-manager.webhook/v3
: Combinesapplication
andcert-manager
overlays. Since we now rely on plain kustomize, let's removev3
and use the standardbase
andoverlays
structure of kustomize.webhook/overlays/application
: Adds an Application CR resource for the poddefaults webhook. We want to remove Application CRs, so this is a good opportunity to do so.webhook/overlays/cert-manager
: Add a cert-manager certificate for the poddefault webhook. This is the only useful overlay and the one that should remain.Recommended end state