Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook-server-rstudio-tidyverse dockerfile and CI/CD #5711

Merged
merged 2 commits into from
Mar 23, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add notebook-server-rstudio-tidyverse dockerfile and CI/CD
  • Loading branch information
davidspek committed Mar 23, 2021
commit 48372b0d897f89fbe07a719c77669c073c4a3242
13 changes: 13 additions & 0 deletions components/example-notebook-servers/rstudio-tidyverse/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
FROM public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/rstudio:master-87b7d015

# Switching to the root user for this installation
# is only necessary when building the image with Kaniko
USER root

RUN conda install --quiet --yes \
'r-tidyverse=1.3.0' && \
conda clean --all -f -y && \
chown -R ${NB_USER}:users $CONDA_DIR && \
chown -R ${NB_USER}:users $HOME

USER $NB_UID
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
""""Argo Workflow for building notebook-server-rstudio-tidyverse's OCI image using Kaniko"""
from kubeflow.kubeflow.cd import config, kaniko_builder


def create_workflow(name=None, namespace=None, bucket=None, **kwargs):
"""
Args:
name: Name to give to the workflow. This can also be used to name
things associated with the workflow.
"""
builder = kaniko_builder.Builder(name=name, namespace=namespace, bucket=bucket, **kwargs)

return builder.build(dockerfile="components/example-notebook-servers/rstudio-tidyverse/Dockerfile",
context="components/example-notebook-servers/rstudio-tidyverse/",
destination=config.NOTEBOOK_SERVER_RSTUDIO_TIDYVERSE)
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# This file is only intended for development purposes
from kubeflow.kubeflow.cd import base_runner

base_runner.main(component_name="notebook_servers.notebook_server_rstudio_tidyverse",
workflow_name="nb-rs-tidy-build")
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
""""Argo Workflow for testing notebook-server-rstudio-tidyverse OCI image"""
from kubeflow.kubeflow.ci import workflow_utils
from kubeflow.testing import argo_build_util


class Builder(workflow_utils.ArgoTestBuilder):
def __init__(self, name=None, namespace=None, bucket=None,
test_target_name=None, **kwargs):
super().__init__(name=name, namespace=namespace, bucket=bucket,
test_target_name=test_target_name, **kwargs)

def build(self):
"""Build the Argo workflow graph"""
workflow = self.build_init_workflow(exit_dag=False)
task_template = self.build_task_template()

# Test building notebook-server-rstudio-tidyverse image using Kaniko
dockerfile = ("%s/components/example-notebook-servers"
"/rstudio-tidyverse/Dockerfile") % self.src_dir
context = "dir://%s/components/example-notebook-servers/rstudio-tidyverse/" % self.src_dir
destination = "notebook-server-rstudio-tidyverse-test"

kaniko_task = self.create_kaniko_task(task_template, dockerfile,
context, destination, no_push=True)
argo_build_util.add_task_to_dag(workflow,
workflow_utils.E2E_DAG_NAME,
kaniko_task, [self.mkdir_task_name])

# Set the labels on all templates
workflow = argo_build_util.set_task_template_labels(workflow)

return workflow


def create_workflow(name=None, namespace=None, bucket=None, **kwargs):
"""
Args:
name: Name to give to the workflow. This can also be used to name
things associated with the workflow.
"""
builder = Builder(name=name, namespace=namespace, bucket=bucket, **kwargs)

return builder.build()
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# This file is only intended for development purposes
from kubeflow.kubeflow.ci import base_runner

base_runner.main(component_name="notebook_servers.notebook_server_rstudio_tidyverse_tests",
workflow_name="nb-rs-tidy-tests")