-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions about releasing TFJob #532
Conversation
* Point to the instructions in tf-operator repo for how to cut and build a tf-operator release. * Need to update the extra repos in the E2E test so we checkout tf-operator at the tag corresponding to the release.
/assign @willb |
/assign @ankushagarwal |
releasing.md
Outdated
The junit files will be in `gs://kubeflow-releasing-artifacts`. | ||
Identify the TFJob [release](https://github.com/kubeflow/tf-operator/releases) you | ||
want to use | ||
* If you need to cut a new TFJob release follow the instructions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: markdown formatting issue here.
@willb Try doing "/lgtm" on this PR to see what I mean about anyone in the org can /lgtm. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
* Update instructions about releasing TFJob * Point to the instructions in tf-operator repo for how to cut and build a tf-operator release. * Need to update the extra repos in the E2E test so we checkout tf-operator at the tag corresponding to the release. * Fix formatting issue.
* tests: go generates invalid tests for platform configs kubeflow#528 * add filtering to changed too
* Update instructions about releasing TFJob * Point to the instructions in tf-operator repo for how to cut and build a tf-operator release. * Need to update the extra repos in the E2E test so we checkout tf-operator at the tag corresponding to the release. * Fix formatting issue.
* fix: Avoid side effect Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Remove Signed-off-by: Ce Gao <gaoce@caicloud.io>
Point to the instructions in tf-operator repo for how to cut and build
a tf-operator release.
Need to update the extra repos in the E2E test so we checkout tf-operator
at the tag corresponding to the release.
Related to #215
This change is