Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions about releasing TFJob #532

Merged
merged 5 commits into from
Apr 4, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Mar 30, 2018

  • Point to the instructions in tf-operator repo for how to cut and build
    a tf-operator release.

  • Need to update the extra repos in the E2E test so we checkout tf-operator
    at the tag corresponding to the release.

Related to #215


This change is Reviewable

* Point to the instructions in tf-operator repo for how to cut and build
  a tf-operator release.

* Need to update the extra repos in the E2E test so we checkout tf-operator
  at the tag corresponding to the release.
@jlewi
Copy link
Contributor Author

jlewi commented Mar 30, 2018

/assign @willb

@jlewi
Copy link
Contributor Author

jlewi commented Apr 2, 2018

/assign @ankushagarwal

releasing.md Outdated
The junit files will be in `gs://kubeflow-releasing-artifacts`.
Identify the TFJob [release](https://github.com/kubeflow/tf-operator/releases) you
want to use
* If you need to cut a new TFJob release follow the instructions in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: markdown formatting issue here.

@jlewi
Copy link
Contributor Author

jlewi commented Apr 2, 2018

@willb Try doing "/lgtm" on this PR to see what I mean about anyone in the org can /lgtm.

@ankushagarwal
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack
Copy link
Member

pdmack commented Apr 4, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 61240be into kubeflow:master Apr 4, 2018
swiftdiaries pushed a commit to swiftdiaries/kubeflow that referenced this pull request Apr 4, 2018
* Update instructions about releasing TFJob

* Point to the instructions in tf-operator repo for how to cut and build
  a tf-operator release.

* Need to update the extra repos in the E2E test so we checkout tf-operator
  at the tag corresponding to the release.

* Fix formatting issue.
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
* tests: go generates invalid tests for platform configs kubeflow#528

* add filtering to changed too
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Update instructions about releasing TFJob

* Point to the instructions in tf-operator repo for how to cut and build
  a tf-operator release.

* Need to update the extra repos in the E2E test so we checkout tf-operator
  at the tag corresponding to the release.

* Fix formatting issue.
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* fix: Avoid side effect

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Remove

Signed-off-by: Ce Gao <gaoce@caicloud.io>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants