Create a new directory in components for web apps #5184
Conversation
Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
|
This change is |
|
web apps is overly general. Not all web apps will use this code. Can you scope it down to the web applications that you will own? Which apps are those? I believe they are 3; jupyter UI, tensorboard, and volume controller. Furthermore, I believe based on your previous PR your writing python code for these web apps? Per: #3578 I believe what you are building is a web app that will manage web apps? So maybe call this something like "web-app-manager"? |
What about
Yes, it will be for the {Jupyter, Tensorboard, Volumes} UIs.
#5164 has the common backend/Python code, which essentially exposes a base backend that adds authnz/logging/probes/serving to any app that will be extending it. So the three mentioned apps will be extending this base app and will be adding their own routes on top. Next, I'll be creating a PR that will contain common Angular code that the three apps' frontends will be sharing. So the structure will be looking like this [ we could also discuss the naming for the common code in their respective PRs ]:
This folder will not be a web app manager, but rather a reordering in order to include the web apps and their common code together. Per #3578, the web app that will be handling a more generalized Kubeflow CR should also live inside this folder, since it will be utilizing the common code. I hope the above clarifies a little bit what I have in mind. |
components/web-apps/OWNERS
Outdated
| - kimwnasptd | ||
| - StefanoFioravanzo | ||
| reviewers: | ||
| - avdaredevil |
There was a problem hiding this comment.
Have @avdaredevil and @prodonjs agreed to participate in this?
Do not duplicate reviewers and approvers. Please refer to
https://www.kubeflow.org/docs/about/contributing/#maintaining-owners-files
There was a problem hiding this comment.
My bad, I just copied the reviewers from the jupyter web app.
Lets start with an empty list of reviewers for now
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
…5184) * Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
…5184) * Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
…5184) * Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
…5184) * Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
…5184) * Create a new directory in components for web apps Since we want to also have some common code between our web apps we should create a parent dir for any future web app we want to develop. The code for the web apps, common or not, should be organized under this directory. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * remove the reviewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
closes #5183
Since we want to also have some common code between our web apps we should create a parent directory for any future web app we want to develop.
The code for the web apps, common or not, should be organized under this directory.
This PR will also be the first step for merging the code from #5164
cc @elikatsis @StefanoFioravanzo @kandrio98
/cc @jlewi
/assign @kimwnasptd