Fix instructions for tensorflow-notebook release #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lluunn
reviewed
Mar 23, 2018
| @@ -114,8 +114,9 @@ REPO_NAME=kubeflow | |||
| ENV=releasing | |||
| ks param set --env=${ENV} workflows namespace kubeflow-releasing | |||
| ks param set --env=${ENV} workflows name "${USER}-${JOB_NAME}-${VERSION_TAG}" | |||
| ks param set --env=${ENV} workflows prow_env "JOB_NAME=${JOB_NAME},JOB_TYPE=${JOB_TYPE},PULL_BASE_SHA=${PULL_BASE_SHA},REPO_NAME=${REPO_NAME},REPO_OWNER=${REPO_OWNER},BUILD_NUMBER=${BUILD_NUMBER}" | |||
| ks param set --env=${ENV} workflows serving_image "gcr.io/kubeflow-images-staging/tf-model-server:${VERSION_TAG}" | |||
|
serving_image param is not used in this workflow.
…On Fri, Mar 23, 2018 at 11:56 AM, Lun-Kai Hsu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In releasing.md
<#494 (comment)>:
> @@ -114,8 +114,9 @@ REPO_NAME=kubeflow
ENV=releasing
ks param set --env=${ENV} workflows namespace kubeflow-releasing
ks param set --env=${ENV} workflows name "${USER}-${JOB_NAME}-${VERSION_TAG}"
-ks param set --env=${ENV} workflows prow_env "JOB_NAME=${JOB_NAME},JOB_TYPE=${JOB_TYPE},PULL_BASE_SHA=${PULL_BASE_SHA},REPO_NAME=${REPO_NAME},REPO_OWNER=${REPO_OWNER},BUILD_NUMBER=${BUILD_NUMBER}"
-ks param set --env=${ENV} workflows serving_image "gcr.io/kubeflow-images-staging/tf-model-server:${VERSION_TAG} <http://gcr.io/kubeflow-images-staging/tf-model-server:$%7BVERSION_TAG%7D>"
why delete this line?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#494 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwpFX8RTgKeEUWL9fSxxqtx4db_09vpks5thUVOgaJpZM4S5NAC>
.
--
Ankush Agarwal
Software Engineer, Cloud ML
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Nov 1, 2019
add application overlay for spartakus
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @lluunn