Kfctl upgrade py test #4191
Closed
Kfctl upgrade py test #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
force-pushed
the
kfctl_upgrade_py_test
branch
from
beac8b0 to
66fbcc7
Compare
jlewi
force-pushed
the
kfctl_upgrade_py_test
branch
from
66fbcc7 to
0703bab
Compare
* We need to write an E2E test for kfctl upgrade (kubeflow/kfctl#35). * This PR defines a new python class to define the upgrade E2E test workflow. * It subclasses the existing e2e_workflow.py in order to reuse the existing logic for building kfctl, deploying kubeflow, and validating kubeflow. * The modified workflow runs kfctl upgrade after first deploying Kubeflow. * This is actually just a place holder which prints out the command to be executed; this will need to be updated after we actually write a pytest to do the upgrade.
jlewi
force-pushed
the
kfctl_upgrade_py_test
branch
from
0703bab to
f4ebea3
Compare
|
/test all |
added 2 commits
November 7, 2019 15:58
|
@jlewi Is this ready for review? |
|
@richardsliu I think its outdated. The PR should probably move over to kubeflow/kfctl; do you want to take it over? |
|
Replaced by kubeflow/kfctl#172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a skeleton workflow for doing upgrades.
We need to write an E2E test for kfctl upgrade (E2E test for kfctl upgrade kfctl#35).
This PR defines a new python class to define the upgrade E2E test workflow.
It subclasses the existing e2e_workflow.py in order to reuse the existing
logic for building kfctl, deploying kubeflow, and validating kubeflow.
The modified workflow runs kfctl upgrade after first deploying Kubeflow.
be executed; this will need to be updated after we actually write a
pytest to do the upgrade.
This change is