Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter UI that manages Notebook CRs #2357

Merged
merged 4 commits into from
Feb 14, 2019
+4,395 −1
Merged

Jupyter UI that manages Notebook CRs #2357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e006a7f
Introduce jupyter-web-app's code under /components
kimwnasptd Jan 25, 2019
928c95d
Add jupyter-web-app component in jupyter pkg
kimwnasptd Jan 25, 2019
c5cf523
UI fixes
kimwnasptd Feb 12, 2019
06b0a1b
Add webapp to init scripts
kimwnasptd Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add webapp to init scripts 
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
  • Loading branch information
@kimwnasptd
kimwnasptd committed Feb 13, 2019
commit 06b0a1b01a661455d312f62b0a49eac791dd8024
2 changes: 1 addition & 1 deletion scripts/kfctl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ source "${DIR}/gke/util.sh"
source "${DIR}/util-minikube.sh"
INPUT=()
FORMAT=()
export KUBEFLOW_COMPONENTS=${DEFAULT_KUBEFLOW_COMPONENTS:-'"ambassador","jupyter","notebooks","centraldashboard","tf-job-operator","pytorch-operator","spartakus","argo","pipeline"'}
export KUBEFLOW_COMPONENTS=${DEFAULT_KUBEFLOW_COMPONENTS:-'"ambassador","jupyter","jupyter-web-app","notebooks","centraldashboard","tf-job-operator","pytorch-operator","spartakus","argo","pipeline"'}
export KUBEFLOW_EXTENDEDINFO=${KUBEFLOW_EXTENDEDINFO:-false}

# envsubst alternative if envsubst is not installed
Expand Down
1 change: 1 addition & 0 deletions scripts/util.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ createKsApp() {
ks generate ambassador ambassador
ks generate openvino openvino
ks generate jupyter jupyter
ks generate jupyter-web-app jupyter-web-app
ks generate centraldashboard centraldashboard
ks generate tf-job-operator tf-job-operator
ks generate tensorboard tensorboard
Expand Down