Jupyter UI that manages Notebook CRs #2357

kimwnasptd · 2019-01-31T20:34:34Z

Description

This PR provides the initial version of the new Web UI to natively spawn Jupyter Notebooks in a Kubeflow environment. The new Jupyter UI aims to replace the existing jupyter component and disengage Kubeflow from the JupyterHub API.

Please note that the new Jupyter UI is still under development, so there will be various fixes/improvements to its appearance and functionality until it’s ready to be merged. This WIP PR will also be updated soon to support the existing 3rd party alternative Jupyter UIs and not just the default one.

To quickly test the new Jupyter UI in your K8s cluster we provide a series of deployment steps. We have already tested those on Minikube, bare metal K8s and GKE. Of course, we welcome feedback and encourage discussion on issues that might arise.

Closes

#1995
#2156
#2232

Depends

#2349
Τhis PR has been updated and now depends on #2456

Main features of the new Jupyter UI

Designed as a native K8s client for managing custom Notebook resources - no intermediate APIs used
Leverages @kam’s Notebook CRD to spawn Notebook Pods via the respective Controller, instead of depending on JH KubeSpawner
Written in Python Flask + plain HTML/jQuery/Material Design Lite. This stack allows reusability of already implemented components and delivery of a frontend that shares similar aesthetic with the central dashboard of Kubeflow.
Currently uses a privileged ServiceAcccount that is allowed to manage Notebook CRs along with PVCs in all namespaces

Future/Related Work

Integration with the new login UI component, as well as @kam’s Profiles when multiple (read/write) ServiceAccounts are supported. The new Jupyter web application will use its own privileged ServiceAccount to dispatch all API requests. In a later iteration it will be using Impersonation.

@jlewi We need to investigate which is the best way to e2e test the new Jupyter component, meaning both user interface and backend. Related to:
Jupyter CR E2E test #2174
Integrate Jupyter e2e test into CI #2333
Create an E2E test for the Jupyter custom resource. #2323
@kam @jlewi We need to implement a watcher on K8s Notebooks so that we retrieve reliable, real-time on the status of each created CR. A good starting point could be to map the status of the Jupyter Notebook to Pod lifecycle states. For this, we might also need to extend the Notebook CRD. This will definitely improve UX and increase visibility on deployed Notebooks.
@jlewi Update the centraldashboard component of Kubeflow to replace “JupyterHub” link with “Notebooks” and route to the new Jupyter UI. As a side change, we would also need to update the corresponding public Docker image on gcr.io for 0.5.

Deployment Steps

(Minor tweaks might be needed depending on your development environment)

Clone the Arrikto Kubeflow repo and checkout the feature-jupyter-web-app branch
git clone -b feature-jupyter-web-app https://www.github.com/arrikto/kubeflow.git
Build the new Jupyter UI Docker image locally on the host running K8s
docker build -t jupyter-web-app:v0.1 kubeflow/components/jupyter-web-app
Initialize the ksonnet application
kubeflow/scripts/kfctl.sh init kf
Generate and apply existing KF components via ksonnet
cd kf && ../kubeflow/scripts/kfctl.sh generate all && ../kubeflow/scripts/kfctl.sh apply all
Instruct the jupyter-web-app KF component to use the image you previously built
cd ks_app && ks param set jupyter-web-app image jupyter-web-app:v0.1
Apply the jupyter-web-app KF component
ks apply default -c jupyter-web-app
Configure your K8s cluster networking and make sure that the Kubeflow central Dashboard is reachable from outside the cluster
Point your browser to http://<KUBEFLOW_IP>/jupyter/ (trailing slash). You should be able to access the dashboard of the new Jupyter UI.
Follow the instructions located at kubeflow/components/jupyter-web-app/README.md to create, connect to and delete Jupyter Notebooks.

This change is

k8s-ci-robot · 2019-01-31T20:34:49Z

Hi @kimwnasptd. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ioandr · 2019-01-31T20:36:51Z

/ok-to-test

jlewi · 2019-01-31T22:49:34Z

/assign @kkasravi @pdmack

pdmack · 2019-02-01T15:57:45Z

Traveling in Europe but might be able to look tomorrow

jlewi · 2019-02-01T19:00:13Z

Related to testing
kubeflow/testing#288 about getting selenium working to write UI based tests.

jlewi · 2019-02-02T21:52:42Z

/assign @jlewi

jlewi

Reviewed 26 of 26 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ellis-bigelow, @kimwnasptd, and @vkoukis)

components/jupyter-web-app/jupyter/routes.py, line 4 at r1 (raw file):

from flask import jsonify, render_template, request
from kubernetes.client.rest import ApiException
from jupyter import app

Is making the top level package named jupyter going to cause problems because it conflicts with the jupyter package?

Should we rename it?

We could make it

from kubeflow.jupyter

I like the idea of beginning to organize our py code into kubeflow sub packages.

Related issue kubeflow/training-operator#914 about better support for namespace packaging.

components/jupyter-web-app/jupyter/server.py, line 21 at r1 (raw file):

def create_client_config(apiserver=APISERVER, ca_cert=CACERT):
    # By default, use JWT Tokens

What is the CERT being used for?

The JWT should be validated in a side car by ISTIO; so the only thing the web app should need to do is get the identity of the user. is that what this code is doing?

components/jupyter-web-app/jupyter/server.py, line 69 at r1 (raw file):

def create_pvc(body):

So the web app will create PVCs? Not just attach them?

components/jupyter-web-app/jupyter/utils.py, line 24 at r1 (raw file):

# Functions for handling the config from which we load the default values

Default values for what? The notebook? Or for the UI?

components/jupyter-web-app/jupyter/utils.py, line 47 at r1 (raw file):

# Helper functions for the /post-notebook route.
def create_notebook_template():

I believe if a CR includes an OpenAPI spec then the client generation tools for K8s can be used to generate python classes for that class. Might be worth file an issue to track that and using that library here.

jlewi · 2019-02-02T22:31:22Z

@kimwnasptd This looks great to me. I mostly looked at the python code.

Hopefully someone with more frontend experience like @avdaredevil can take a look at the front end stuff.

Is there specific issues or questions that need to be resolved? In other words what's still in progress? If nothing and its ready to review please go ahead and remove WIP from the title to signal to reviewers that its read to be reviewed.

If you want to block it from being merged you can put a hold on it.

kimwnasptd

Yes. currently we've added extra privileges to the webapp's service account to list/edit/get/delete Notebooks, PVCs and Namespces. Then the webapp uses this sa's token for any call to the api server. Is this enough for now or should it use impersonation as described in the design doc?

Also there are some last bits we need to work on the UI to have the same functionality with the current implementation. We'll be ready to remove the WIP label within the week.

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ellis-bigelow, @jlewi, and @vkoukis)

components/jupyter-web-app/jupyter/routes.py, line 4 at r1 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Is making the top level package named jupyter going to cause problems because it conflicts with the jupyter package?

Should we rename it?

We could make it

from kubeflow.jupyter

I like the idea of beginning to organize our py code into kubeflow sub packages.

Related issue kubeflow/training-operator#914 about better support for namespace packaging.

I think I'm missing something here. Are you referring to the /kubeflow/jupyter package? Won't the code for the UIs be under /components/jupyter-web-app/?

components/jupyter-web-app/jupyter/server.py, line 21 at r1 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

What is the CERT being used for?

The JWT should be validated in a side car by ISTIO; so the only thing the web app should need to do is get the identity of the user. is that what this code is doing?

No, that cert is used from the client to verify the server's certificate for ssl. Also, the webapp does all the api calls using its own privileged service account token. I was waiting for the ISTIO implementation to progress and then I would update the code to use the identity of the user with impersonation.

components/jupyter-web-app/jupyter/server.py, line 69 at r1 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

So the web app will create PVCs? Not just attach them?

Yes, this was also present with JupyterHub so I preserved this feature. Should I not?

components/jupyter-web-app/jupyter/utils.py, line 24 at r1 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Default values for what? The notebook? Or for the UI?

For the UI. They are default values to put in the form. These are loaded from a file in /kubeflow/jupyter/config.yaml and are attached as a ConfigMap to the webapp

components/jupyter-web-app/jupyter/utils.py, line 47 at r1 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

I believe if a CR includes an OpenAPI spec then the client generation tools for K8s can be used to generate python classes for that class. Might be worth file an issue to track that and using that library here.

Thanks for the heads up, I'll look into it right away

jlewi · 2019-02-05T00:40:48Z

Yes. currently we've added extra privileges to the webapp's service account to list/edit/get/delete Notebooks, PVCs and Namespces. Then the webapp uses this sa's token for any call to the api server. Is this enough for now or should it use impersonation as described in the design doc?

Yes this is fine.

Also there are some last bits we need to work on the UI to have the same functionality with the current implementation. We'll be ready to remove the WIP label within the week.

What is this functionality? Can we do it in a follow on PR and get the initial version merged?

jlewi

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ellis-bigelow, @kimwnasptd, and @vkoukis)

components/jupyter-web-app/jupyter/routes.py, line 4 at r1 (raw file):

Previously, kimwnasptd (Kimonas Sotirchos) wrote…

I think I'm missing something here. Are you referring to the /kubeflow/jupyter package? Won't the code for the UIs be under /components/jupyter-web-app/?

I'm referring to your python package.

Right now you are treating jupyter as a top level python package; i.e. you import it as

from jupyter import app

i.e. you are adding the directory components/jupyter-web-app to your PYTHONPATH.

This will cause a conflict if someone has the actual jupyter package installed on their path because that would also be imported as

import jupyter

So we should try to come up with a unique enough naming that things won't conflict.

So one way to do that is to organize the code as

component/jupyter-web-app/kubeflow/jupyter

And add

component/jupyter-web-app

to your python path

Then the code would be imported as

import kubeflow.jupyter

which should avoid conflicts with the jupyter package.

components/jupyter-web-app/jupyter/server.py, line 21 at r1 (raw file):

Previously, kimwnasptd (Kimonas Sotirchos) wrote…

No, that cert is used from the client to verify the server's certificate for ssl. Also, the webapp does all the api calls using its own privileged service account token. I was waiting for the ISTIO implementation to progress and then I would update the code to use the identity of the user with impersonation.

What does SSL validation have to do with ISTIO and service accounts?

I don't think you need to verify SSL certificates or generate JWTs.

To talk to the K8s master using the pods service account you should just be able to configure the K8s python client library in a way that it automatically uses the PODs service account.

components/jupyter-web-app/jupyter/server.py, line 69 at r1 (raw file):

Previously, kimwnasptd (Kimonas Sotirchos) wrote…

Yes, this was also present with JupyterHub so I preserved this feature. Should I not?

I think its fine.

components/jupyter-web-app/jupyter/utils.py, line 24 at r1 (raw file):

Previously, kimwnasptd (Kimonas Sotirchos) wrote…

For the UI. They are default values to put in the form. These are loaded from a file in /kubeflow/jupyter/config.yaml and are attached as a ConfigMap to the webapp

Can you clarify the comment please.

components/jupyter-web-app/jupyter/utils.py, line 47 at r1 (raw file):

Previously, kimwnasptd (Kimonas Sotirchos) wrote…

Thanks for the heads up, I'll look into it right away

I would suggest filing a follow on issue; lets not block the current PR on it.

jlewi · 2019-02-08T21:37:07Z

@kimwnasptd How's it going? Any idea on when you'll have the next iteration of this PR?

avdaredevil

Took a quick look at the front-end changes. Here are my thoughts.

Let me know if you have any questions/updates :)

avdaredevil · 2019-02-11T21:47:08Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+
+function deleteNotebook(ns, nb) {
+  $.getJSON(prefix + "/delete-notebook", { namespace:ns, notebook:nb}, function(data, status) {
+    var innerHTML = $("#error-msgs").html()


This declaration is redundant, could simply be:

let innerHTML = ''

avdaredevil · 2019-02-11T21:50:16Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+      innerHTML  = '<div class="alert alert-warning">';
+      innerHTML += '<span class="close" '
+      innerHTML += 'onclick="this.parentElement.style.display=\'none\';">&times;</span>';
+      innerHTML += '<strong>Warning! </strong>' + data.log + ' </div>';


This seems to be XSS prone. Maybe consider doing something like:

innerHTML = ` <div class="alert alert-warning"> <span class="close" onclick="this.parentElement.style.display='none'">×</span> <strong>Warning!</strong><span class='warning-log'></span> </div>`

and on line 24:

const $e = $("#error-msgs").html(innerHTML) $('.warning-log', $e).text(data.log) // This will not fail even if your `innerText` is empty

avdaredevil · 2019-02-11T21:50:28Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+      innerHTML += 'onclick="this.parentElement.style.display=\'none\';">&times;</span>';
+      innerHTML += '<strong>Warning! </strong>' + data.log + ' </div>';
+    }
+    $("#error-msgs").html(innerHTML);


avdaredevil · 2019-02-11T21:51:26Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+    var innerHTML = $("#error-msgs").html()
+    if(data.success == true) {
+      updateNotebooksInNamespace(ns)
+      innerHTML  = '';


This is not needed if the above change is made

avdaredevil · 2019-02-11T21:55:07Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+};
+
+function connectNotebook(ns, nb) {
+  window.open("/" + ns + "/" + nb, "_blank");


[nitpick] This could be written as:

window.open(`/${ns}/${nb}`, "_blank");

avdaredevil · 2019-02-11T22:02:14Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+  updateNotebooksInNamespace(ns);
+
+  // Change the function for the CREATE NOTEBOOK button
+  $("#create-nb-btn").attr("onclick", "createNotebook('" + ns + "')")


Perhaps go with:

$("#create-nb-btn").click(_ => createNotebook(ns))

OR

$("#create-nb-btn").click(createNotebook.bind(0, ns))

avdaredevil · 2019-02-11T22:02:52Z

components/jupyter-web-app/jupyter/static/js/notebooks.js

+  updateNotebooksInNamespace(ns);
+
+  // Change the function for the CREATE NOTEBOOK button
+  $("#create-nb-btn").attr("onclick", "createNotebook('" + ns + "')")


Same as review above

googlebot · 2019-02-13T15:32:47Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Add the webapp's code to /components/jupyter-web-app. It is a basic Flask application with HTML/CSS/jQuery. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Add the jsonnet files in /kubeflow/jupyter. Currently the webapp is used alongside JupyterHub. The webapp is under the prefix /jupyter. The image param of the jupyter-web-app must be configured before deploying. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Fixes noted from avdaredevil: * Fix XSS vulnerability * Use template literals for HTML inside JS Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

googlebot · 2019-02-13T15:58:13Z

CLAs look good, thanks!

avdaredevil · 2019-02-14T00:27:27Z

/lgtm

jlewi

Once its committed we'll push the image to the registry. We want to limit who has access to our public image registry.

Reviewed 39 of 41 files at r2.
Reviewable status: 33 of 35 files reviewed, 10 unresolved discussions (waiting on @avdaredevil, @ellis-bigelow, @kimwnasptd, and @vkoukis)

components/jupyter-web-app/rok/kubeflow/rokui/server.py, line 3 at r2 (raw file):

import json
from kubernetes import client, config
from kubernetes.config import ConfigException

Why do we need to duplicate this file for the rokui and the non rokui?

Maybe file an issue to reduce this code duplication?

components/jupyter-web-app/rok/kubeflow/rokui/utils.py, line 6 at r2 (raw file):

# Functions for handling the JWT token

Same question about code duplication with non rokui

kubeflow/jupyter/prototypes/notebooks.jsonnet, line 11 at r2 (raw file):

// @optionalParam registry string gcr.io The docker image registry for notebook
// @optionalParam repoName string kubeflow-images-public The repository name for the notebook
// @optionalParam disks string null Comma separated list of Google persistent disks to attach to notebook environments.

Did you mean to change this file?

kimwnasptd

Reviewable status: 33 of 35 files reviewed, 10 unresolved discussions (waiting on @avdaredevil, @ellis-bigelow, @jlewi, and @vkoukis)

components/jupyter-web-app/rok/kubeflow/rokui/server.py, line 3 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Why do we need to duplicate this file for the rokui and the non rokui?

Maybe file an issue to reduce this code duplication?

Good point. We were planning to file a follow up issue and PR to refactor the python code in order to have a Class-based approach, which would be more extendable.
Although this will happen after the demo, but I'll file the issue to keep track of it

components/jupyter-web-app/rok/kubeflow/rokui/utils.py, line 6 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Same question about code duplication with non rokui

same as above

kubeflow/jupyter/prototypes/notebooks.jsonnet, line 11 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Did you mean to change this file?

Don't think so, I can't see this file being changed locally or in the commits in GitHub. Is it shown as edited?

jlewi

Reviewable status: 33 of 35 files reviewed, 7 unresolved discussions (waiting on @avdaredevil, @ellis-bigelow, and @vkoukis)

jlewi · 2019-02-14T21:15:28Z

/approve
/lgtm

k8s-ci-robot · 2019-02-14T21:15:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Introduce jupyter-web-app's code under /components Add the webapp's code to /components/jupyter-web-app. It is a basic Flask application with HTML/CSS/jQuery. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Add jupyter-web-app component in jupyter pkg Add the jsonnet files in /kubeflow/jupyter. Currently the webapp is used alongside JupyterHub. The webapp is under the prefix /jupyter. The image param of the jupyter-web-app must be configured before deploying. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * UI fixes Fixes noted from avdaredevil: * Fix XSS vulnerability * Use template literals for HTML inside JS Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Add webapp to init scripts Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

k8s-ci-robot added the do-not-merge/work-in-progress label Jan 31, 2019

k8s-ci-robot requested review from ellistarn and vkoukis January 31, 2019 20:34

k8s-ci-robot added size/XXL needs-ok-to-test labels Jan 31, 2019

googlebot added the cla: yes label Jan 31, 2019

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Jan 31, 2019

k8s-ci-robot assigned kkasravi and pdmack Jan 31, 2019

kimwnasptd mentioned this pull request Feb 1, 2019

Add kimwnasptd to github org kubeflow/internal-acls#56

Merged

k8s-ci-robot assigned jlewi Feb 2, 2019

jlewi suggested changes Feb 2, 2019

View reviewed changes

kimwnasptd commented Feb 4, 2019

View reviewed changes

jlewi suggested changes Feb 5, 2019

View reviewed changes

avdaredevil reviewed Feb 11, 2019

View reviewed changes

vkoukis mentioned this pull request Feb 12, 2019

Issues with the current Go notebook controller #2456

Closed

kimwnasptd force-pushed the feature-jupyter-web-app branch from 0617c83 to 75c9112 Compare February 13, 2019 15:32

k8s-ci-robot removed the do-not-merge/work-in-progress label Feb 13, 2019

kimwnasptd changed the title ~~Jupyter UI that manages Notebook CRs~~ WIP - Jupyter UI that manages Notebook CRs Feb 13, 2019

k8s-ci-robot added the do-not-merge/work-in-progress label Feb 13, 2019

kimwnasptd added 4 commits February 13, 2019 17:56

Introduce jupyter-web-app's code under /components

e006a7f

Add the webapp's code to /components/jupyter-web-app. It is a basic Flask application with HTML/CSS/jQuery. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

UI fixes

c5cf523

Fixes noted from avdaredevil: * Fix XSS vulnerability * Use template literals for HTML inside JS Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Add webapp to init scripts

06b0a1b

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

kimwnasptd force-pushed the feature-jupyter-web-app branch from 75c9112 to 06b0a1b Compare February 13, 2019 15:58

googlebot added the cla: yes label Feb 13, 2019

kimwnasptd changed the title ~~WIP - Jupyter UI that manages Notebook CRs~~ Jupyter UI that manages Notebook CRs Feb 13, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress label Feb 13, 2019

k8s-ci-robot assigned avdaredevil Feb 14, 2019

k8s-ci-robot added the lgtm label Feb 14, 2019

jlewi suggested changes Feb 14, 2019

View reviewed changes

kimwnasptd commented Feb 14, 2019

View reviewed changes

jlewi approved these changes Feb 14, 2019

View reviewed changes

k8s-ci-robot added the approved label Feb 14, 2019

k8s-ci-robot merged commit 67190d7 into kubeflow:master Feb 14, 2019

This was referenced Feb 19, 2019

Jupyter notebook manager UI that uses the new CRD #1995

Closed

Jupyter spawner UI should provide a warning if pod isn't backed by durable storage #2156

Closed

vkoukis mentioned this pull request Feb 21, 2019

UX Discussion: Nomenclature about notebooks / Jupyter #2521

Closed

sarahmaddox mentioned this pull request Mar 27, 2019

Document the new Jupyter web app as a component of Kubeflow kubeflow/website#561

Closed

kimwnasptd deleted the feature-jupyter-web-app branch May 19, 2021 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jupyter UI that manages Notebook CRs #2357

Jupyter UI that manages Notebook CRs #2357

kimwnasptd commented Jan 31, 2019 •

edited

Loading

k8s-ci-robot commented Jan 31, 2019

ioandr commented Jan 31, 2019

jlewi commented Jan 31, 2019

pdmack commented Feb 1, 2019

jlewi commented Feb 1, 2019

jlewi commented Feb 2, 2019

jlewi left a comment

jlewi commented Feb 2, 2019

kimwnasptd left a comment

jlewi commented Feb 5, 2019

jlewi left a comment

jlewi commented Feb 8, 2019

avdaredevil left a comment

avdaredevil Feb 11, 2019

avdaredevil Feb 11, 2019

avdaredevil Feb 11, 2019

avdaredevil Feb 11, 2019

avdaredevil Feb 11, 2019

avdaredevil Feb 11, 2019

avdaredevil Feb 11, 2019

googlebot commented Feb 13, 2019

googlebot commented Feb 13, 2019

avdaredevil commented Feb 14, 2019

jlewi left a comment

kimwnasptd left a comment

jlewi left a comment

jlewi commented Feb 14, 2019

k8s-ci-robot commented Feb 14, 2019

Jupyter UI that manages Notebook CRs #2357

Jupyter UI that manages Notebook CRs #2357

Conversation

kimwnasptd commented Jan 31, 2019 • edited Loading

Description

Closes

Depends

Main features of the new Jupyter UI

Future/Related Work

Deployment Steps

k8s-ci-robot commented Jan 31, 2019

ioandr commented Jan 31, 2019

jlewi commented Jan 31, 2019

pdmack commented Feb 1, 2019

jlewi commented Feb 1, 2019

jlewi commented Feb 2, 2019

jlewi left a comment

Choose a reason for hiding this comment

jlewi commented Feb 2, 2019

kimwnasptd left a comment

Choose a reason for hiding this comment

jlewi commented Feb 5, 2019

jlewi left a comment

Choose a reason for hiding this comment

jlewi commented Feb 8, 2019

avdaredevil left a comment

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

avdaredevil Feb 11, 2019

Choose a reason for hiding this comment

googlebot commented Feb 13, 2019

googlebot commented Feb 13, 2019

avdaredevil commented Feb 14, 2019

jlewi left a comment

Choose a reason for hiding this comment

kimwnasptd left a comment

Choose a reason for hiding this comment

jlewi left a comment

Choose a reason for hiding this comment

jlewi commented Feb 14, 2019

k8s-ci-robot commented Feb 14, 2019

kimwnasptd commented Jan 31, 2019 •

edited

Loading