Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image pull policy for pipeline #2251

Merged

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Jan 9, 2019

fixes: #2249


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Jan 13, 2019

/assign @IronPan

@jinchihe Sorry for the slow review. Feel free to ping people on kubeflow.slack.com if they aren't being responsive.

Looks like the PR got out of date; would you mind sync'ing and updating it?

@jinchihe jinchihe force-pushed the update_image_pull_policy_for_pipeline branch from 0da7b64 to f538c39 Compare January 14, 2019 06:27
@jinchihe
Copy link
Member Author

@jlewi @IronPan Done. Thanks.

@IronPan
Copy link
Member

IronPan commented Jan 14, 2019

thanks for the change

@IronPan
Copy link
Member

IronPan commented Jan 14, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 35c725e into kubeflow:master Jan 14, 2019
@jinchihe jinchihe deleted the update_image_pull_policy_for_pipeline branch January 15, 2019 00:17
IronPan added a commit to IronPan/kubeflow that referenced this pull request Jan 23, 2019
accidentally included in kubeflow#2251. remove it to clean up the registry
k8s-ci-robot pushed a commit that referenced this pull request Jan 23, 2019
accidentally included in #2251. remove it to clean up the registry
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
accidentally included in kubeflow#2251. remove it to clean up the registry
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
accidentally included in kubeflow#2251. remove it to clean up the registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest to update the imagePullPolicy to "IfNotPresent" for Pipeline component
5 participants