Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final readme fixes #16

Merged
merged 4 commits into from
Dec 7, 2017
Merged

Final readme fixes #16

merged 4 commits into from
Dec 7, 2017

Conversation

foxish
Copy link
Contributor

@foxish foxish commented Dec 7, 2017

@foxish foxish mentioned this pull request Dec 7, 2017
Closed
aronchick
aronchick reviewed Dec 7, 2017
View reviewed changes
README.md Outdated
## Components

### JupyterHub
Refer to the README in the [tensorflow/k8s](https://github.com/tensorflow/k8s) repository for more information on using the TfJob controller to run TensorFlow jobs on K8s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fond of sending people to another repo to read up on how to use. Can we keep the instructions inline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions are a bit complex - @jlewi PTAL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some sample config but retained pointer to more detailed docs. @aronchick PTAL.

@foxish
Copy link
Contributor Author

foxish commented Dec 7, 2017

Merging. @vishh, if you have any concerns, please let me know. Will address in follow-up.

@foxish foxish merged commit 6234a9a into kubeflow:master Dec 7, 2017
@foxish foxish deleted the update-readme branch December 7, 2017 16:24
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this pull request Mar 5, 2019
@r2d4 @k8s-ci-robot
add mrick to google-kubeflow team (kubeflow#16)
52c196a
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
@andreyvelich @k8s-ci-robot
Add serviceaccount to Katib-ui deploy (kubeflow#16)
fc43769
VaishnaviHire pushed a commit to VaishnaviHire/kubeflow that referenced this pull request May 19, 2022
@openshift-merge-robot
Merge pull request kubeflow#16 from kubeflow/master
3edd3a9 
[pull] master from kubeflow:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronchick aronchick aronchick left review comments

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foxish @aronchick @jlewi