Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to kubeform_spawner.py (form UI and others) #1551

Merged
merged 0 commits into from
Oct 11, 2018
Merged

Improvements to kubeform_spawner.py (form UI and others) #1551

merged 0 commits into from
Oct 11, 2018

Conversation

tlkh
Copy link

@tlkh tlkh commented Sep 18, 2018 •
edited by jlewi
Loading

Changes

1. UI
Improved spawner layout, with optional (example) bulletin showing
The bulletin was very useful at my university. It is commented out in the code by default.
screen shot 2018-09-18 at 12 04 21 pm
For comparison, the original spawner from master
screen shot 2018-09-18 at 12 08 38 pm

2. Some other issues in kubeform_spawner.py

  • Replace double quotes (") with single quotes by default ('), if not it may cause JSON parsing errors on older installations (0.2.x tested)
  • Commented out GitHubOAuthenticator since it is not being used
  • Added error handling in case DEFAULT_JUPYTERLAB env variable is not found
  • Added some comments on adding additonal PVC

I'm a first time contributor, please let me know if I'm doing something wrong!

On a side note, I am developing our own flavour of the Spawner UI for my university. Here's what it looks like, if there are other parts worth merging as well, please highlight!

screen shot 2018-09-17 at 12 18 47 am

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @tlkh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pdmack
Copy link
Member

pdmack commented Sep 18, 2018

/hold

I'm working on some modifications to allow people to have their own spawner "skins" like this. Will consult some of the ideas here.

@ankushagarwal ankushagarwal removed their request for review September 30, 2018 01:43
@tlkh tlkh mentioned this pull request Sep 30, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented Oct 1, 2018

See also discussion in #34 and #1630

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ea41d61 into kubeflow:master Oct 11, 2018
@ioandr ioandr mentioned this pull request Oct 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsliu richardsliu Awaiting requested review from richardsliu

Assignees
No one assigned
Labels
approved cla: no do-not-merge/hold needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlkh @k8s-ci-robot @pdmack @jlewi @googlebot