Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create links on kubeflow.org to redirect to ksonnet tarballs and deploy scripts #1156

Closed
jlewi opened this issue Jul 9, 2018 · 7 comments
Closed

Create links on kubeflow.org to redirect to ksonnet tarballs and deploy scripts #1156

jlewi opened this issue Jul 9, 2018 · 7 comments
Labels
area/0.3.0 priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 9, 2018

We would like the getting started experience to be something like

curl https://kubeflow.org/version/0.2.1/scripts/deploy.sh | bash

To support that we'd like to host links in kubeflow.org that will automatically redirect to

  1. The scripts containing the code for a specific version/release
  2. Tarballs of the ksonnet registry (to avoid GitHub API limits) see Make downloading our ksonnet registry for getting started efficient #1154

We'd also like to create links that point to the most recent release and head e.g.

curl https://kubeflow.org/version/stable/scripts/deploy.sh | bash
curl https://kubeflow.org/version/head/scripts/deploy.sh | bash

So that its easy for users to automatically get the latest release or version.

What should the URL structure be? Proposal

Proposal 1:

https://kubeflow.org/version/${VERSION}/${PLATFORM}/scripts/deploy.sh 
https://kubeflow.org/version/${VERSION}/source.tar.gz

Proposal 2:

https://kubeflow.org/version/${VERSION}/scripts/${PLATFORM}/deploy.sh 
https://kubeflow.org/version/${VERSION}/source.tar.gz

Anybody know off hand how we could use hugo to easily have these URLs mapped to GitHub URLs e.g.

For source.tar.gz we can just grab the links from our releases page
https://github.com/kubeflow/kubeflow/releases
@activatedgeek
Copy link
Contributor

We could create a releases page which has embedded JS to do the following things

  1. Fetch all releases from https://api.github.com/repos/kubeflow/kubeflow/releases. This is a public API, does not requires auth and will run client-side. Unless somebody keeps reloading aimlessly, it is unlikely that the rate-limiting happens for the client.

  2. Populate the JSON from 1. into HTML dynamically for users to click and download.

An alternative for 1. is to instead of using netlify builds, we use the custom build server like we do for Kubeflow, and just before doing the Hugo build step, we grab the releases and put them into a markdown file just like Hugo needs. This has a chance of rate-limit from happening so only run this on release tags and skip otherwise.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 9, 2018

@richardsliu Do you want to look into this.

@ankushagarwal
Copy link
Contributor

ankushagarwal commented Jul 13, 2018 •
edited
Loading

Can't we just use curl https://raw.githubusercontent.com/kubeflow/kubeflow/<version>/scripts/gke/deploy.sh | bash for now?

@jlewi
Copy link
Contributor Author

jlewi commented Jul 13, 2018 via email

@jlewi
Copy link
Contributor Author

jlewi commented Jul 19, 2018

It looks like netify might support this
https://www.netlify.com/docs/redirects/

@jlewi jlewi mentioned this issue Jul 19, 2018
Merged
@jlewi
Copy link
Contributor Author

jlewi commented Jul 22, 2018

This works you can now do

curl -L https://kubeflow.org/version/stable/scripts/deploy.sh

An alternative idea raised in #96 was force pushing Git tags.

But as @pdmack suggested that can get squirrelly.

The next step is probably #1239 so that you don't have to specify the version in two places. See this comment

@pdmack
Copy link
Member

pdmack commented Jul 23, 2018

@jlewi I wonder if "version/stable" is required? i.e., https://kubeflow.org/scripts/deploy.sh implicitly pointing to 0.2.2? WDYT?

@ghost ghost mentioned this issue Oct 10, 2019
Closed
@pourquoi42 pourquoi42 mentioned this issue Apr 21, 2020
Closed
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
@adrian555 @yuzisun
kustomize v3 for kfserving and knative (kubeflow#1156)
48624db 
* update kfserving to kustomize v3

* add kustomize v3 for knative

* update expected for test

* update to address comments

* update to address comments

* update expected test data

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update tests/legacy_kustomizations/knative-install/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Update knative/kubeflow/kustomization.yaml

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* move kfserving to v0.3.0

* update kfdefs

* revert back to use kubeflow namespace

* address kubeflow-gateway comment

* update expected knative-install configmap

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/0.3.0 priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlewi @ankushagarwal @pdmack @activatedgeek