Latest.

kubeflow · Sep 20, 2019 · b1dcdb4 · b1dcdb4
1 parent 488fdaa
commit b1dcdb4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/prow_config.yaml b/prow_config.yaml
@@ -83,7 +83,6 @@ workflows:
       - testing/kfctl/*
     kwargs:
       use_basic_auth: true
-      use_istio: true
       config_path: https://raw.githubusercontent.com/kubeflow/manifests/master/kfdef/kfctl_gcp_basic_auth.yaml
   # Run unittests
   # TODO(jlewi): Need to add step to run go and python unittests

diff --git a/py/kubeflow/kubeflow/ci/kfctl_e2e_workflow.py b/py/kubeflow/kubeflow/ci/kfctl_e2e_workflow.py
@@ -624,6 +624,9 @@ def build(self):
 
     return self.workflow
 
+# TODO(jlewi): This is an unnecessary layer of indirection around the builder
+# We should allow py_func in prow_config to point to the builder and
+# let e2e_tool take care of this.
 def create_workflow(**kwargs): # pylint: disable=too-many-statements
   """Create workflow returns an Argo workflow to test kfctl upgrades.