Adding changes to build nb-controller on pull_request (#7054)

kubeflow · Mar 23, 2023 · 9426201 · 9426201
1 parent 86e0cdb
commit 9426201
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/nb_controller_intergration_test.yaml b/.github/workflows/nb_controller_intergration_test.yaml
@@ -17,11 +17,18 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v3
+
+    - name: Setup QEMU
+      uses: docker/setup-qemu-action@v2
+
+    - name: Setup Docker Buildx
+      uses: docker/setup-buildx-action@v2
 
     - name: Build Notebook Controller Image 
       run: |
         cd components/notebook-controller
-        make docker-build 
+        ARCH=linux/ppc64le make docker-build-multi-arch
+        ARCH=linux/amd64 make docker-build-multi-arch
 
     - name: Install KinD
       run: ./components/testing/gh-actions/install_kind.sh

diff --git a/components/notebook-controller/Makefile b/components/notebook-controller/Makefile
@@ -98,7 +98,7 @@ docker-push: ## Push docker image with the manager.
 
 .PHONY: docker-build-multi-arch
 docker-build-multi-arch: ##  Build multi-arch docker images with docker buildx
-	cd .. && docker buildx build --platform ${ARCH} --tag ${IMG}:${TAG} -f ./notebook-controller/Dockerfile .
+	cd .. && docker buildx build --load --platform ${ARCH} --tag ${IMG}:${TAG} -f ./notebook-controller/Dockerfile .
 
 
 .PHONY: docker-build-push-multi-arch