tests(notebook-controller): fix unintended shadowing of cfg variable

This is a nasty Go gotcha, and we aren't the first to have trouble with it https://temporal.io/blog/go-shadowing-bad-choices#the-bug
kubeflow · Nov 24, 2024 · 74bebb2 · 74bebb2
1 parent 4275d99
commit 74bebb2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/components/notebook-controller/controllers/suite_test.go b/components/notebook-controller/controllers/suite_test.go
@@ -59,7 +59,8 @@ var _ = BeforeSuite(func() {
 		ErrorIfCRDPathMissing: true,
 	}
 
-	cfg, err := testEnv.Start()
+	var err error
+	cfg, err = testEnv.Start()
 	Expect(err).NotTo(HaveOccurred())
 	Expect(cfg).NotTo(BeNil())