Skip to content

Commit

Permalink
Fix get use_basic_auth.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeremy Lewi committed Sep 24, 2019
1 parent 0364236 commit 271eb66
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions testing/kfctl/kfctl_go_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ def set_env_init_args(use_basic_auth, use_istio):
# Set ENV for basic auth username/password.
if use_basic_auth:
# Don't log the password.
logging.info("Seeting environment variables KUBEFLOW_USERNAME and KUBEFLOW_PASSWORD")
logging.info("Setting environment variables KUBEFLOW_USERNAME and KUBEFLOW_PASSWORD")
os.environ["KUBEFLOW_USERNAME"] = "kf-test-user"
os.environ["KUBEFLOW_PASSWORD"] = str(uuid.uuid4().hex)
init_args = ["--use_basic_auth"]
else:
# Owned by project kubeflow kubeflow-ci-deployment
logging.info("Seeting environment variables CLIENT_SECRET and CLIENT_ID")
logging.info("Setting environment variables CLIENT_SECRET and CLIENT_ID")
os.environ["CLIENT_SECRET"] = "CJ4qVPLTi0j0GJMkONj7Quwt"
os.environ["CLIENT_ID"] = (
"29647740582-7meo6c7a9a76jvg54j0g2lv8lrsb4l8g"
Expand Down Expand Up @@ -202,10 +202,10 @@ def test_build_kfctl_go(app_path, project, use_basic_auth, use_istio, config_pat

# TODO(jlewi): When we switch to KfDef v1beta1 this logic will need to change because
# use_base_auth will move into the plugin spec
use_basic_auth = config_spec.get("useBasicAuth", False)
use_basic_auth = config_spec["spec"].get("useBasicAuth", False)
logging.info("use_basic_auth=%s", use_basic_auth)

use_istio = config_spec.get("useIstio", True)
use_istio = config_spec["spec"].get("useIstio", True)
logging.info("use_istio=%s", use_istio)

# Set ENV for basic auth username/password.
Expand Down

0 comments on commit 271eb66

Please sign in to comment.